linux-kernel - Re: [PATCH v8] usb: typec: ucsi: add Lenovo Yoga C630 glue driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAA8EJpqNd45CF+hw-fqXzUT51+6wmxYy3R8UBxzH+9C3AcgO+g@mail.gmail.com>
Date: Mon, 24 Jun 2024 18:09:19 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Bjorn Andersson <andersson@...nel.org>, Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>, 
	"Bryan O'Donoghue" <bryan.odonoghue@...aro.org>, 
	Heikki Krogerus <heikki.krogerus@...ux.intel.com>, Konrad Dybcio <konrad.dybcio@...aro.org>, 
	linux-kernel@...r.kernel.org, platform-driver-x86@...r.kernel.org, 
	linux-usb@...r.kernel.org, linux-arm-msm@...r.kernel.org, 
	Nikita Travkin <nikita@...n.ru>
Subject: Re: [PATCH v8] usb: typec: ucsi: add Lenovo Yoga C630 glue driver

On Mon, 24 Jun 2024 at 17:43, Greg Kroah-Hartman
<gregkh@...uxfoundation.org> wrote:
>
> On Mon, Jun 24, 2024 at 05:37:05PM +0300, Dmitry Baryshkov wrote:
> > On Mon, 24 Jun 2024 at 17:25, Greg Kroah-Hartman
> > <gregkh@...uxfoundation.org> wrote:
> > >
> > > On Fri, Jun 21, 2024 at 01:21:26AM +0300, Dmitry Baryshkov wrote:
> > > > The Lenovo Yoga C630 WOS laptop provides implements UCSI interface in
> > > > the onboard EC. Add glue driver to interface the platform's UCSI
> > > > implementation.
> > > >
> > > > Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
> > > > Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
> > > > Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
> > > > ---
> > > > Add driver for the UCSI on the Lenovo Yoga C630 laptop, as implemented
> > > > by the Embedded Controlller of the laptop.
> > > >
> > > > Support for this EC was implemented by Bjorn, who later could not work
> > > > on this driver. I've picked this patchset up and updated it following
> > > > the pending review comments.
> > > >
> > > > NOTE: the patch depends on the header from the platform driver. Ilpo
> > > > Järvinen has created an immutable branch based on v6.10-rc1, please pull
> > > > it before merging the patches:
> > > >
> > > >   https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git tags/platform-drivers-x86-ib-lenovo-c630-v6.11
> > > >
> > > >   platform: arm64: add Lenovo Yoga C630 WOS EC driver (2024-06-14 12:51:30 +0300)
> > >
> > > I have that branch, yet when building this driver as a module I get the
> > > following errors:
> > > ERROR: modpost: "yoga_c630_ec_unregister_notify" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
> > > ERROR: modpost: "yoga_c630_ec_ucsi_get_version" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
> > > ERROR: modpost: "yoga_c630_ec_register_notify" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
> > > ERROR: modpost: "yoga_c630_ec_ucsi_write" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
> > > ERROR: modpost: "yoga_c630_ec_ucsi_read" [drivers/usb/typec/ucsi/ucsi_yoga_c630.ko] undefined!
> > >
> > > So something went wrong :(
> > >
> > > I'll unwind that branch pull now as well and wait for a fixed up version
> > > to be sent.
> >
> > Could you please share your .config? I could not reproduce the issue
> > here. The EC driver has all the necessary EXPORT_SYMBOL_GPL()
> > declarations.
>
> Sure, attached.

Thanks! Fixed in v9, drivers/platform/Kconfig issue.

-- 
With best wishes
Dmitry