linux-kernel - Re: [PATCH v3] binder: frozen notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAN5Drs0i7KZHXnrhHRT-KrLs5ZAYGOpixHk-CU=Ah+ycqxkwOQ@mail.gmail.com>
Date: Mon, 24 Jun 2024 20:01:02 -0700
From: Yu-Ting Tseng <yutingtseng@...gle.com>
To: cmllamas@...gle.com, tkjos@...gle.com, gregkh@...uxfoundation.org
Cc: arve@...roid.com, maco@...roid.com, joel@...lfernandes.org, 
	brauner@...nel.org, surenb@...gle.com, aliceryhl@...gle.com, 
	kernel-team@...roid.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] binder: frozen notification

On Mon, Jun 24, 2024 at 10:22 AM Yu-Ting Tseng <yutingtseng@...gle.com> wrote:
>
> Yu-Ting Tseng (1):
>   binder: frozen notification
>
>  drivers/android/binder.c            | 300 +++++++++++++++++++++++++++-
>  drivers/android/binder_internal.h   |  23 ++-
>  include/uapi/linux/android/binder.h |  35 ++++
>  3 files changed, 354 insertions(+), 4 deletions(-)
>
> > freeze was allocated with kzalloc(), you could drop the "= false".
> Done.
>
> > If !node->proc then process is dead. Do we really need to continue?
> Update the code to return an error early if the process is already dead.
>
> > This access to node->proc->* doesn't seem safe
> Added locking.
>
> > Why do we queue this notification?
> Yes, this is to get the current state back to userspace. The userspace API delivers an initial event for the current state upon a listener registration, which makes it easier to track what the latest state is.
>
> > I'm looking at the death notification code and it seems it only queues a
> BR_ERROR after failing to allocate a "death" and that other errors are
> silently ignored?
> Sure. Please let me know if you think we need a change here.
>
> > these could be just bitfields.
> Done
>
> > freeze->work.type = BINDER_WORK_CLEAR_DEATH_NOTIFICATION
> Fixed. Working on a userspace test. Will post a link when it's ready.
New test now included in the aosp patch:
https://android-review.googlesource.com/c/platform/frameworks/native/+/3070045/6/libs/binder/tests/binderDriverInterfaceTest.cpp
>
> base-commit: 14d7c92f8df9c0964ae6f8b813c1b3ac38120825
> --
> 2.45.2.741.gdbec12cfda-goog
>