linux-kernel - Re: [PATCH v3 8/9] selftests/arm: Add ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4c6d78fb-50d7-43fd-8e1b-9619c34eab59@sirena.org.uk>
Date: Tue, 25 Jun 2024 19:18:29 +0100
From: Mark Brown <broonie@...nel.org>
To: Dev Jain <dev.jain@....com>
Cc: shuah@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, Catalin.Marinas@....com,
	will@...nel.org, ryan.roberts@....com, rob.herring@....com,
	mark.rutland@....com, linux@...linux.org.uk, suzuki.poulose@....com,
	Anshuman.Khandual@....com, aneesh.kumar@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 8/9] selftests/arm: Add ptrace_64 test

On Tue, Jun 25, 2024 at 05:54:07PM +0530, Dev Jain wrote:

> +static int do_child(void)
> +{
> +	if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
> +		ksft_exit_fail_perror("PTRACE_TRACEME");
> +
> +	/* SIGTRAP makes the child stop after exec; do_parent() resumes it */
> +	execv("trivial_32bit_program", NULL);
> +	return EXIT_SUCCESS;
> +}

We should check that the execv() worked, one thing that can go wrong is
partially installing the tests or trying to run the tests in a different
directory to the one where everything is installed.  I'd be inclined to
specify the path as ./ too to avoid surprises.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)