linux-kernel - Re: [PATCH 2/5] ACPI: sysfs: use device lifecycle for

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a72495c3-c996-4be7-bc64-ba10d5400971@sirena.org.uk>
Date: Tue, 25 Jun 2024 21:57:13 +0100
From: Mark Brown <broonie@...nel.org>
To: Thomas Weißschuh <linux@...ssschuh.net>
Cc: "Rafael J. Wysocki" <rafael@...nel.org>, Len Brown <lenb@...nel.org>,
	Robert Moore <robert.moore@...el.com>, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org, acpica-devel@...ts.linux.dev,
	Aishwarya.TCV@....com
Subject: Re: [PATCH 2/5] ACPI: sysfs: use device lifecycle for _STR result

On Thu, Jun 13, 2024 at 10:15:33PM +0200, Thomas Weißschuh wrote:
> The string assigned to dev->pnp.str effectively shares the lifetime of
> the device. Use devm_-APIs to avoid a manual cleanup path.
> 
> This will be useful when the attributes themselves will be managed by
> the device core.

This is in -next since 20240624 and appears to be causing issues on
Cavium Thunder X2 in the Arm lab - with arm64 defconfig we see a bunch
of log messages like:

<6>[   50.120962] ACPI: button: Power Button [PWRB]
<6>[   50.120962] ACPI: button: Power Button [PWRB]
<2>[   50.138595] acpi LNXTHERM:00: Resources present before probing
<2>[   50.138595] acpi LNXTHERM:00: Resources present before probing
<2>[   50.150873] acpi LNXTHERM:01: Resources present before probing
<2>[   50.150873] acpi LNXTHERM:01: Resources present before probing
<2>[   50.163134] acpi LNXTHERM:02: Resources present before probing
<2>[   50.163134] acpi LNXTHERM:02: Resources present before probing
<2>[   50.175393] acpi LNXTHERM:03: Resources present before probing
<2>[   50.175393] acpi LNXTHERM:03: Resources present before probing
<2>[   50.187653] acpi LNXTHERM:04: Resources present before probing
<2>[   50.187653] acpi LNXTHERM:04: Resources present before probing
<2>[   50.199913] acpi LNXTHERM:05: Resources present before probing
<2>[   50.199913] acpi LNXTHERM:05: Resources present before probing
<2>[   50.212171] acpi LNXTHERM:06: Resources present before probing
<2>[   50.212171] acpi LNXTHERM:06: Resources present before probing
<2>[   50.224433] acpi LNXTHERM:07: Resources present before probing
<2>[   50.224433] acpi LNXTHERM:07: Resources present before probing
<2>[   50.236703] acpi LNXTHERM:08: Resources present before probing

(some other bug seems to be doubling all the log lines.)  We also see
PCI getting upset:

<6>[   50.238119] pcieport 0000:00:03.0: Refused to change power state from D0 to D3hot

and the ethernet driver gets confused:

[ 71.592299] mlx5_core 0000:0b:00.1: Port module event: module 1, Cable unplugged

while the cable is most definitely connected, we're netbooting.  A
bisect pointed at this commit, full bisect log below:

git bisect start
# status: waiting for both good and bad commits
# bad: [62c97045b8f720c2eac807a5f38e26c9ed512371] Add linux-next specific files for 20240624
git bisect bad 62c97045b8f720c2eac807a5f38e26c9ed512371
# status: waiting for good commit(s), bad commit known
# good: [f2661062f16b2de5d7b6a5c42a9a5c96326b8454] Linux 6.10-rc5
git bisect good f2661062f16b2de5d7b6a5c42a9a5c96326b8454
# bad: [dff8aaf6c690e2a3ff1ece04a78d494e7111b97f] Merge branch 'master' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git
git bisect bad dff8aaf6c690e2a3ff1ece04a78d494e7111b97f
# good: [0dcf65f1a6999ce2efcce2d956c43698ad5cb910] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/s390/linux.git
git bisect good 0dcf65f1a6999ce2efcce2d956c43698ad5cb910
# bad: [1da968e3bbd7ea713af0a23ff6b708772d024691] Merge branch 'cpufreq/arm/linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/vireshk/pm.git
git bisect bad 1da968e3bbd7ea713af0a23ff6b708772d024691
# good: [998d61dc008b677c845a0c7ef69dcb1d2b3d5546] Merge branch 'for-next' of git://git.kernel.org/pub/scm/linux/kernel/git/printk/linux.git
git bisect good 998d61dc008b677c845a0c7ef69dcb1d2b3d5546
# good: [5dc494b479a6e7c4a4425bb353c25b219e07c894] Merge branch 'hwmon-next' of git://git.kernel.org/pub/scm/linux/kernel/git/groeck/linux-staging.git
git bisect good 5dc494b479a6e7c4a4425bb353c25b219e07c894
# good: [156922faabcef2979cb2ddc2fbaa659b5ea37f54] media: atomisp: Switch to new Intel CPU model defines
git bisect good 156922faabcef2979cb2ddc2fbaa659b5ea37f54
# good: [2b582118f1f42928129922c94a174f0cc42b38fe] Merge branch 'thermal-intel' into linux-next
git bisect good 2b582118f1f42928129922c94a174f0cc42b38fe
# good: [d499aee48012b899f5bc814fef9021520411cab7] Merge branch 'docs-mw' into docs-next
git bisect good d499aee48012b899f5bc814fef9021520411cab7
# bad: [1c524c86afa8555e8add0c83c9d58e147cdf8f23] Merge branch 'pm-cpufreq' into linux-next
git bisect bad 1c524c86afa8555e8add0c83c9d58e147cdf8f23
# good: [70d80903e265dc81e2bf390e5b301a32b2344ff4] Merge branch 'thermal' into linux-next
git bisect good 70d80903e265dc81e2bf390e5b301a32b2344ff4
# bad: [fe66d86311693574aca1b9624f92e273c13d1b3b] ACPI: sysfs: remove return value of acpi_device_setup_files()
git bisect bad fe66d86311693574aca1b9624f92e273c13d1b3b
# bad: [30fb30aa9ab68e0f638ae775de6284c41e8910b2] ACPI: sysfs: use device lifecycle for _STR result
git bisect bad 30fb30aa9ab68e0f638ae775de6284c41e8910b2
# good: [3fd84db96b212a321ad381bf0341f45f952285b7] ACPI: sysfs: convert utf-16 from _STR to utf-8 only once
git bisect good 3fd84db96b212a321ad381bf0341f45f952285b7
# first bad commit: [30fb30aa9ab68e0f638ae775de6284c41e8910b2] ACPI: sysfs: use device lifecycle for _STR result

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)