linux-kernel - Re: [PATCH v5 2/2] iio: light: ROHM BH1745 colour sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 01:44:37 +0200
From: Javier Carrasco <javier.carrasco.cruz@...il.com>
To: Mudit Sharma <muditsharma.info@...il.com>, jic23@...nel.org,
 lars@...afoo.de, krzk+dt@...nel.org, conor+dt@...nel.org, robh@...nel.org
Cc: ivan.orlov0322@...il.com, linux-kernel@...r.kernel.org,
 linux-iio@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 2/2] iio: light: ROHM BH1745 colour sensor

On 25/06/2024 21:25, Mudit Sharma wrote:
> On 24/06/2024 23:27, Javier Carrasco wrote:
>>
>>> +static int bh1745_set_trigger_state(struct iio_trigger *trig, bool
>>> state)
>>> +{
>>> +    int ret;
>>
>> Why is value initialized here? If regmap returns an error, you will not
>> use value anyway. I caught my eye because it is initialized here, and
>> not in the other functions where you use the same pattern.
> 
> Hi Javier,
> 
> Thank you for the review on this.
> 
> 'value' is initialized here for case when we un-set the trigger. In that
> case, 'state' will be false and 'value' of 0 (default value for
> BH1745_INTR register) will be written.
> 

I missed that case. Thanks for clarifying.

By the way, it might be beneficial to wait a bit longer before sending a
new version to give more reviewers a chance to look at your series.

24 hours might be a bit too short, and your version count could easily
skyrocket if more reviewers get involved.

Best regards,
Javier Carrasco