[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f9f5178b-1e94-489b-8e71-43b814b7252a@ti.com>
Date: Tue, 25 Jun 2024 14:01:30 +0530
From: Vignesh Raghavendra <vigneshr@...com>
To: Jayesh Choudhary <j-choudhary@...com>, <linux-kernel@...r.kernel.org>,
<nm@...com>, <j-luthra@...com>
CC: <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
<conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
<devicetree@...r.kernel.org>, <u-kumar1@...com>
Subject: Re: [PATCH 1/3] arm64: dts: ti: k3-j784s4-main: Add McASP nodes
On 19/06/24 15:22, Jayesh Choudhary wrote:
> Add McASP 0-4 instances and keep them disabled as several required
> properties are missing as they are board specific.
>
> Signed-off-by: Jayesh Choudhary <j-choudhary@...com>
> ---
> arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi | 80 ++++++++++++++++++++++
> 1 file changed, 80 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> index fd3d3344efbe..96085dc7bc18 100644
> --- a/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j784s4-main.dtsi
> @@ -2617,4 +2617,84 @@ dss_ports: ports {
> */
> };
> };
> +
> + mcasp0: mcasp@...0000 {
> + compatible = "ti,am33xx-mcasp-audio";
> + reg = <0x0 0x02b00000 0x0 0x2000>,
> + <0x0 0x02b08000 0x0 0x1000>;
^^ Should be 0x00 (elsewhere as well) to be inline with rest of the file
> + reg-names = "mpu","dat";
> + interrupts = <GIC_SPI 544 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 545 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> + dmas = <&main_udmap 0xc400>, <&main_udmap 0x4400>;
> + dma-names = "tx", "rx";
> + clocks = <&k3_clks 265 1>;
> + clock-names = "fck";
> + power-domains = <&k3_pds 265 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> + };
> +
> + mcasp1: mcasp@...0000 {
> + compatible = "ti,am33xx-mcasp-audio";
> + reg = <0x0 0x02b10000 0x0 0x2000>,
> + <0x0 0x02b18000 0x0 0x1000>;
> + reg-names = "mpu","dat";
> + interrupts = <GIC_SPI 546 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 547 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> + dmas = <&main_udmap 0xc401>, <&main_udmap 0x4401>;
> + dma-names = "tx", "rx";
> + clocks = <&k3_clks 266 1>;
> + clock-names = "fck";
> + power-domains = <&k3_pds 266 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> + };
> +
> + mcasp2: mcasp@...0000 {
> + compatible = "ti,am33xx-mcasp-audio";
> + reg = <0x0 0x02b20000 0x0 0x2000>,
> + <0x0 0x02b28000 0x0 0x1000>;
> + reg-names = "mpu","dat";
> + interrupts = <GIC_SPI 548 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 549 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> + dmas = <&main_udmap 0xc402>, <&main_udmap 0x4402>;
> + dma-names = "tx", "rx";
> + clocks = <&k3_clks 267 1>;
> + clock-names = "fck";
> + power-domains = <&k3_pds 267 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> + };
> +
> + mcasp3: mcasp@...0000 {
> + compatible = "ti,am33xx-mcasp-audio";
> + reg = <0x0 0x02b30000 0x0 0x2000>,
> + <0x0 0x02b38000 0x0 0x1000>;
> + reg-names = "mpu","dat";
> + interrupts = <GIC_SPI 550 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 551 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> + dmas = <&main_udmap 0xc500>, <&main_udmap 0x4500>;
> + dma-names = "tx", "rx";
> + clocks = <&k3_clks 268 1>;
> + clock-names = "fck";
> + power-domains = <&k3_pds 268 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> + };
> +
> + mcasp4: mcasp@...0000 {
> + compatible = "ti,am33xx-mcasp-audio";
> + reg = <0x0 0x02b40000 0x0 0x2000>,
> + <0x0 0x02b48000 0x0 0x1000>;
> + reg-names = "mpu","dat";
> + interrupts = <GIC_SPI 552 IRQ_TYPE_LEVEL_HIGH>,
> + <GIC_SPI 553 IRQ_TYPE_LEVEL_HIGH>;
> + interrupt-names = "tx", "rx";
> + dmas = <&main_udmap 0xc501>, <&main_udmap 0x4501>;
> + dma-names = "tx", "rx";
> + clocks = <&k3_clks 269 1>;
> + clock-names = "fck";
> + power-domains = <&k3_pds 269 TI_SCI_PD_EXCLUSIVE>;
> + status = "disabled";
> + };
> };
--
Regards
Vignesh
Powered by blists - more mailing lists