linux-kernel - Re: [PATCH 3/3] arm64: dts: ti: k3-j784s4-evm: Enable analog audio support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <22f4b2ac-cf38-494b-84e4-0d09b545b303@ti.com>
Date: Mon, 24 Jun 2024 13:22:49 +0530
From: Jayesh Choudhary <j-choudhary@...com>
To: Vignesh Raghavendra <vigneshr@...com>, <linux-kernel@...r.kernel.org>,
        <nm@...com>, <j-luthra@...com>
CC: <kristo@...nel.org>, <robh@...nel.org>, <krzk+dt@...nel.org>,
        <conor+dt@...nel.org>, <linux-arm-kernel@...ts.infradead.org>,
        <devicetree@...r.kernel.org>, <u-kumar1@...com>
Subject: Re: [PATCH 3/3] arm64: dts: ti: k3-j784s4-evm: Enable analog audio
 support

Hello Vignesh,

On 22/06/24 12:14, Vignesh Raghavendra wrote:
> 
> 
> On 19/06/24 15:22, Jayesh Choudhary wrote:
>> &wkup_pmx2 {
>> @@ -881,6 +917,14 @@ exp1: gpio@20 {
>>   				  "PCIE0_4L_RC_RSTZ", "PCIE0_4L_EP_RST_EN", "PCIE1_4L_PRSNT#",
>>   				  "PCIE0_4L_PRSNT#", "CDCI1_OE1/OE4", "CDCI1_OE2/OE3",
>>   				  "AUDIO_MUX_SEL", "EXP_MUX2", "EXP_MUX3", "GESI_EXP_PHY_RSTZ";
>> +
>> +		p12-hog {
>> +			/* P12 - AUDIO_MUX_SEL */
>> +			gpio-hog;
>> +			gpios = <12 GPIO_ACTIVE_HIGH>;
>> +			output-low;
>> +			line-name = "AUDIO_MUX_SEL";
>> +		};
>>   	};
>>   
>>   	exp2: gpio@22 {
>> @@ -896,6 +940,22 @@ exp2: gpio@22 {
>>   				  "CANUART_MUX1_SEL1", "ENET1_EXP_PWRDN", "ENET1_EXP_RESETZ",
>>   				  "ENET1_I2CMUX_SEL", "ENET1_EXP_SPARE2", "ENET2_EXP_RESETZ",
>>   				  "USER_INPUT1", "USER_LED1", "USER_LED2";
>> +
>> +		p13-hog {
>> +			/* P13 - CANUART_MUX_SEL0 */
>> +			gpio-hog;
>> +			gpios = <13 GPIO_ACTIVE_HIGH>;
>> +			output-high;
>> +			line-name = "CANUART_MUX_SEL0";
>> +		};
>> +
>> +		p15-hog {
>> +			/* P15 - CANUART_MUX1_SEL1 */
>> +			gpio-hog;
>> +			gpios = <15 GPIO_ACTIVE_HIGH>;
>> +			output-high;
>> +			line-name = "CANUART_MUX1_SEL1";
>> +		};
>>   	};
>>   };
> 
> 
> Does this break CAN instances already enabled in the dts? If you
> consider making this a overlay as defaults seem to be set for CAN
> 

This does not break CAN.
The only issue was with p14-hog that was being used by can-3 instance
as mux-gpio and hogging it here was making the resource busy for can.
That I have handled with the idle-state in the gpio mux itself.

Thanks,
Jayesh