linux-kernel - Re: [PATCH] drm/nouveau/dispnv04: fix null pointer dereference in nv17_tv_get_hd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7969a4e-61aa-479f-89c8-0373e84c43be@web.de>
Date: Tue, 25 Jun 2024 16:34:17 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Ma Ke <make24@...as.ac.cn>, nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, Daniel Vetter <daniel@...ll.ch>,
 Danilo Krummrich <dakr@...hat.com>, David Airlie <airlied@...il.com>,
 Karol Herbst <kherbst@...hat.com>, Lyude Paul <lyude@...hat.com>
Cc: stable@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/nouveau/dispnv04: fix null pointer dereference in
 nv17_tv_get_hd_modes

> In nv17_tv_get_hd_modes(), the return value of drm_mode_duplicate() is
> assigned to mode, which will lead to a possible NULL pointer dereference
> on failure of drm_mode_duplicate(). The same applies to drm_cvt_mode().
> Add a check to avoid null pointer dereference.

Can a wording approach (like the following) be a better change description?

  A null pointer is stored in the local variable “mode” after a call
  of the function “drm_cvt_mode” or “drm_mode_duplicate” failed.
  This pointer was used in subsequent statements where an undesirable
  dereference will be performed then.
  Thus add corresponding return value checks.

> Cc: stable@...r.kernel.org

Would you like to add the tag “Fixes” accordingly?

How do you think about to use a summary phrase like
“Prevent null pointer dereferences in nv17_tv_get_hd_modes()”?

Regards,
Markus