linux-kernel - Re: [PATCH v3 5/9] selftests/arm64: Fix build warnings for ptrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 25 Jun 2024 15:35:43 +0100
From: Mark Brown <broonie@...nel.org>
To: Dev Jain <dev.jain@....com>
Cc: shuah@...nel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kselftest@...r.kernel.org, Catalin.Marinas@....com,
	will@...nel.org, ryan.roberts@....com, rob.herring@....com,
	mark.rutland@....com, linux@...linux.org.uk, suzuki.poulose@....com,
	Anshuman.Khandual@....com, aneesh.kumar@...nel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 5/9] selftests/arm64: Fix build warnings for ptrace

On Tue, Jun 25, 2024 at 05:54:04PM +0530, Dev Jain wrote:

> "%s" should have been used in ksft_exit_fail_msg(). Anyways, replace that
> with the recently introduced ksft_exit_fail_perror(). Also fix no mention of
> type_name in ksft_test_result_skip().

Reviewed-by: Mark Brown <broonie@...nel.org>

but a couple of minor notes if this needs resending (it might be best to
send indpendently as well to help it get picked up more quickly.)

> NOTE: This patch can be applied independently of the series, but the
> next patch depends on this one.

Admin notes like this should go after the ---.

>  	if (ptrace(PTRACE_TRACEME, -1, NULL, NULL))
> -		ksft_exit_fail_msg("PTRACE_TRACEME", strerror(errno));
> +		ksft_exit_fail_perror("PTRACE_TRACEME");
>  
>  	if (raise(SIGSTOP))
> -		ksft_exit_fail_msg("raise(SIGSTOP)", strerror(errno));
> +		ksft_exit_fail_perror("raise(SIGSTOP)");

This should ideally be a separate patch, there's no overlap.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)