[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f647756a-fa9b-4a97-8c33-826f7496821f@redhat.com>
Date: Wed, 26 Jun 2024 16:19:20 +0200
From: Jocelyn Falempe <jfalempe@...hat.com>
To: Geert Uytterhoeven <geert+renesas@...der.be>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>
Cc: dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drm/panic: Do not select DRM_KMS_HELPER
On 26/06/2024 10:41, Geert Uytterhoeven wrote:
> DRM core code cannot call into DRM helper code, as this would lead to
> circular references in the modular case. Hence drop the selection of
> DRM_KMS_HELPER. It was unused anyway, as v10 switched from using
> the DRM format helpers to its own color format conversion, cfr. commit
> 9544309775c334c9 ("drm/panic: Add support for color format
> conversion")).
Thanks a lot for this cleanup,
Reviewed-by: Jocelyn Falempe <jfalempe@...hat.com>
>
> Remove the unneeded include of <drm/drm_format_helper.h>.
>
> Fixes: bf9fb17c6672868d ("drm/panic: Add a drm panic handler")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> ---
> drivers/gpu/drm/Kconfig | 1 -
> drivers/gpu/drm/drm_panic.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig
> index b903a2c0b5e8f95c..ce9bf2b6e9d332d4 100644
> --- a/drivers/gpu/drm/Kconfig
> +++ b/drivers/gpu/drm/Kconfig
> @@ -108,7 +108,6 @@ config DRM_KMS_HELPER
> config DRM_PANIC
> bool "Display a user-friendly message when a kernel panic occurs"
> depends on DRM && !(FRAMEBUFFER_CONSOLE && VT_CONSOLE)
> - select DRM_KMS_HELPER
> select FONT_SUPPORT
> help
> Enable a drm panic handler, which will display a user-friendly message
> diff --git a/drivers/gpu/drm/drm_panic.c b/drivers/gpu/drm/drm_panic.c
> index 8d2eded1fd19ff6c..67f78b5a76b61e3d 100644
> --- a/drivers/gpu/drm/drm_panic.c
> +++ b/drivers/gpu/drm/drm_panic.c
> @@ -20,7 +20,6 @@
> #include <linux/types.h>
>
> #include <drm/drm_drv.h>
> -#include <drm/drm_format_helper.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_framebuffer.h>
> #include <drm/drm_modeset_helper_vtables.h>
Powered by blists - more mailing lists