[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240626151343.GA2504017@google.com>
Date: Wed, 26 Jun 2024 16:13:43 +0100
From: Lee Jones <lee@...nel.org>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>
Cc: Fabrice Gasnier <fabrice.gasnier@...s.st.com>,
William Breathitt Gray <wbg@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
linux-pwm@...r.kernel.org, linux-stm32@...md-mailman.stormreply.com,
linux-iio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-kernel@...r.kernel.org,
Thorsten Scherer <T.Scherer@...elmann.de>
Subject: Re: [PATCH v2 0/5] mfd: stm32-timers: Make register definition more
flexible
On Wed, 19 Jun 2024, Uwe Kleine-König wrote:
> Hello,
>
> (implicit) v1 is available at
> https://lore.kernel.org/lkml/cover.1718352022.git.u.kleine-koenig@baylibre.com
> .
>
> Changes introduced here:
>
> - Split the patch removing TIM_DIER_CC_IE() and use appropriate subject
> prefixes. Lee and William didn't like the patch touching both
> include/linux/mfd/stm32-timers.h and
> drivers/counter/stm32-timer-cnt.c not having a hint to the counter
> subsystem (at least that's my interpretation of their feedback).
> Not mentioning mfd didn't seem to be considerably better in my eyes,
> so I split this patch.
> - Fix typo noticed by Thorsten.
> - Update subject prefix of the last patch to match what is usually done
> for pwm.
>
> I have some further updates to the pwm-stm32 driver that will probably
> go in before v6.10-rc1. They shouldn't conflict, still I'd prefer to let
> the pwm patch go in via my tree as I might have some further changes for
> that driver. So if this is merged using the mfd or counter tree, please
> skip the pwm patch. A stable branch would be welcome in this case.
>
> Best regards
> Uwe
>
>
> Uwe Kleine-König (5):
> mfd: stm32-timers: Unify alignment of register definition
> mfd: stm32-timers: Add some register definitions with a parameter
> counter: stm32-timer-cnt: Use TIM_DIER_CCxIE(x) instead of
> TIM_DIER_CCxIE(x)
> mfd: stm32-timers: Drop unused TIM_DIER_CC_IE
> pwm: stm32: Make use of parametrised register definitions
>
> drivers/counter/stm32-timer-cnt.c | 4 +-
> drivers/pwm/pwm-stm32.c | 22 ++--
> include/linux/mfd/stm32-timers.h | 179 ++++++++++++++++--------------
> 3 files changed, 107 insertions(+), 98 deletions(-)
>
> base-commit: 1613e604df0cd359cf2a7fbd9be7a0bcfacfabd0
Applied patches 1-4 and submitted for build testing.
If all is good, I'll sent out a PR for William.
Note to self: ib-mfd-counter-5.11
--
Lee Jones [李琼斯]
Powered by blists - more mailing lists