linux-kernel - Re: [PATCH 1/1] leds: core: Omit set_brightness error message for a LED supporting hw trigger only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240626155615.GF2504017@google.com>
Date: Wed, 26 Jun 2024 16:56:15 +0100
From: Lee Jones <lee@...nel.org>
To: Heiner Kallweit <hkallweit1@...il.com>
Cc: linux-kernel@...r.kernel.org, Pavel Machek <pavel@....cz>,
	linux-leds@...r.kernel.org
Subject: Re: [PATCH 1/1] leds: core: Omit set_brightness error message for a
 LED supporting hw trigger only

On Mon, 24 Jun 2024, Heiner Kallweit wrote:

> On 20.06.2024 11:09, Lee Jones wrote:
> > On Thu, 13 Jun 2024, Lee Jones wrote:
> > 
> >> If both set_brightness functions return -ENOTSUPP, then the LED doesn't
> >> support setting a fixed brightness value, and the error message isn't
> >> helpful. This can be the case e.g. for LEDs supporting a specific hw
> >> trigger only.
> >>
> >> Pinched the subject line and commit message from Heiner:
> >> Link: https://lore.kernel.org/all/44177e37-9512-4044-8991-bb23b184bf37@gmail.com/
> >>
> >> Reworked the function to provide Heiner's required semantics whilst
> >> simultaneously increasing readability and flow.
> >>
> >> Cc: Pavel Machek <pavel@....cz>
> >> Cc: linux-leds@...r.kernel.org
> >> Suggested-by: Heiner Kallweit <hkallweit1@...il.com>
> > 
> > Heiner, you good with this solution?
> > 
> > A Tested-by or Reviewed-by would be good if you have the time.
> > 
> >> Signed-off-by: Lee Jones <lee@...nel.org>
> 
> Reviewed-by: Heiner Kallweit <hkallweit1@...il.com>

Added, thank you.

-- 
Lee Jones [李琼斯]