Message-ID: <667c3a4a.5d0a0220.bf738.7cca@mx.google.com>
Date: Wed, 26 Jun 2024 17:57:04 +0200
From: Christian Marangi <ansuelsmth@...il.com>
To: Lee Jones <lee@...nel.org>
Cc: Pavel Machek <pavel@....cz>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jacek Anaszewski <jacek.anaszewski@...il.com>,
	linux-leds@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v7 00/20] leds: leds-lp55xx: overhaul driver

On Wed, Jun 26, 2024 at 04:42:55PM +0100, Lee Jones wrote:
> On Thu, 20 Jun 2024, Christian Marangi wrote:
> 
> > This long series is (as requested) a big overhaul of the lp55xx based
> > LED driver.
> > 
> > As notice for these kind of LED chip there was the bad habit of copy
> > the old driver and just modify it enough to make it work with the new
> > model. Till v4 I was also doing the same by following the pattern and
> > the code format of previous driver.
> > 
> > Since Lee didn't like this, here is the BIG series that generalize
> > pretty much anything in the 4 model currently supported.
> > 
> > Indeed, although the LED chip have fundamental difference (page
> > support), things can be generalized and produce slimmer drivers by
> > putting everything in the lp55xx-common shared module.
> > 
> > This result in the new model lp5569 being very small with only the
> > selftest portion to be custom.
> > 
> > Lee also wasn't clear by the meaning of ENGINE in these LED driver,
> > so here some simple explaination. This is very common on these TI LED
> > chip. The ENGINE (there are always 3) is just some kind of processor
> > that execute a program (precompiled code ASM like) loaded in the SRAM.
> > Sysfs is used to load the pattern, and to start and stop the engine.
> > 
> > These pattern can do all kind of complex thing with LEDs. Old LED chip
> > had 32bytes of space for the pattern but newer one (like lp5569) have
> > pages and if correctly configured can have massive pattern.
> > These pattern can do all kind of magic like loops that make the LED
> > pulse, change color and all kind of stuff.
> > 
> > (For Lee, sorry if you will have to repeat some review that I might
> >  have missed in the lp5569 driver)
> > 
> > Changes v7:
> > - Add Suggested-by tag
> > - Fix checkpatch error for complex macro (rework define)
> > - Add missing values for fader conversion
> > - Align some function with redundant new line
> > - Capitalize every commit title
> > Changes v6:
> > - Fix compilation warning for ret unused in read_poll_timeout
> >   (no idea why this is flagged only on some particular arch...)
> > - Fix missing bitfield.h in lp55x-common.c (again it seems this
> >   header gets included in the flow if the arch use them or not...)
> > Changes v5:
> > - Big generalization patch
> > - Rework lp5569 driver with new generalized functions
> > - Drop all copyright header in lp5569 as the driver got reworked
> >   entirely and it's not based on previous one anymore.
> > Changes v4:
> > - Fix reported buffer overflow due to a copypaste error
> > - Add comments to describe fw size logic
> > Changes v3:
> > - Add ACK tag to DT patch
> > - Enlarge and support program size up to 128bytes
> > Changes v2:
> > - Add ACK tag to DT patch
> > - Fix compilation error with target that doesn't
> >   include bitfield.h
> > 
> > Christian Marangi (20):
> >   dt-bindings: leds-lp55xx: Limit pwr-sel property to ti,lp8501
> >   dt-bindings: leds-lp55xx: Add new ti,lp5569 compatible
> >   leds: leds-lp55xx: Generalize stop_all_engine OP
> >   leds: leds-lp55xx: Generalize probe/remove functions
> >   leds: leds-lp55xx: Generalize load_engine function
> >   leds: leds-lp55xx: Generalize load_engine_and_select_page function
> >   leds: leds-lp55xx: Generalize run_engine function
> >   leds: leds-lp55xx: Generalize update_program_memory function
> >   leds: leds-lp55xx: Generalize firmware_loaded function
> >   leds: leds-lp55xx: Generalize led_brightness function
> >   leds: leds-lp55xx: Generalize multicolor_brightness function
> >   leds: leds-lp55xx: Generalize set_led_current function
> >   leds: leds-lp55xx: Generalize turn_off_channels function
> >   leds: leds-lp55xx: Generalize stop_engine function
> >   leds: leds-lp55xx: Generalize sysfs engine_load and engine_mode
> >   leds: leds-lp55xx: Generalize sysfs engine_leds
> >   leds: leds-lp55xx: Generalize sysfs master_fader
> >   leds: leds-lp55xx: Support ENGINE program up to 128 bytes
> >   leds: leds-lp55xx: Drop deprecated defines
> >   leds: leds-lp5569: Add support for Texas Instruments LP5569
> > 
> >  .../devicetree/bindings/leds/leds-lp55xx.yaml |  11 +
> >  drivers/leds/Kconfig                          |  16 +-
> >  drivers/leds/Makefile                         |   1 +
> >  drivers/leds/leds-lp5521.c                    | 405 +---------
> >  drivers/leds/leds-lp5523.c                    | 734 ++---------------
> >  drivers/leds/leds-lp5562.c                    | 261 +-----
> >  drivers/leds/leds-lp5569.c                    | 544 +++++++++++++
> >  drivers/leds/leds-lp55xx-common.c             | 743 +++++++++++++++++-
> >  drivers/leds/leds-lp55xx-common.h             | 163 ++--
> >  drivers/leds/leds-lp8501.c                    | 313 +-------
> >  10 files changed, 1540 insertions(+), 1651 deletions(-)
> >  create mode 100644 drivers/leds/leds-lp5569.c
> 
> For whatever reason, this no longer applies.
> 
> Please rebase it on Linux -next or for-leds-next and resubmit.
>

Hi Lee.,

I just checked and yes there is to rebase the series due to
c0e3d2beeb03 ("leds: Drop explicit initialization of struct
i2c_device_id::driver_data to 0")

But I notice that something went bad in reverting some commits from the
v7 series and in for-leds-next there are still 3 commit to drop

mainly 
- 3bed6364ffd0057bd10c081d2e24aa7e8555e0a8
- 3bcc6d6ad7821aa459826592f830d76a3dc6f79f
- 5a402b40c651baf758ad884aed36c0ea70cd8b1e

I'm sending v8 with everything rebased but please keep in mind that
those commits needs to be reverted as the leds one also somehow got half
applied (no idea what happen)

-- 
	Ansuel

Powered by blists - more mailing lists