lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <dceas2m3mllvmoidacnaube7erjvjyrjkis23ppfxboclnnlxq@nlfagnp2ze7y>
Date: Wed, 26 Jun 2024 18:04:01 +0200
From: Andi Shyti <andi.shyti@...nel.org>
To: Arnd Bergmann <arnd@...nel.org>
Cc: Hans Hu <hanshu@...oxin.com>, 
	Wolfram Sang <wsa+renesas@...g-engineering.com>, Arnd Bergmann <arnd@...db.de>, Wentong Wu <wentong.wu@...el.com>, 
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org, 
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] i2c: viai2c: turn common code into a proper module

Hi,

...

> +EXPORT_SYMBOL_GPL(viai2c_init);
> +
> +MODULE_DESCRIPTION("Via/Wondermedia/Zhaoxin I2C master-mode bus adapter");
> +MODULE_AUTHOR("Tony Prisk <linux@...sktech.co.nz>");

Do we want to add also Hans here?

> +MODULE_LICENSE("GPL");

...

> +static irqreturn_t wmt_i2c_isr(int irq, void *data)
> +{

...

> +	/* All the data has been successfully transferred or error occurred */
> +	if (i2c->ret)
> +		complete(&i2c->complete);
> +
> +	return IRQ_HANDLED;
> +}
> +
> +

I took the freedom to remove this double blank line.

>  static int wmt_i2c_probe(struct platform_device *pdev)
>  {
>  	struct device_node *np = pdev->dev.of_node;

...

> @@ -239,6 +298,16 @@ static int zxi2c_probe(struct platform_device *pdev)
>  	if (error)
>  		return error;
>  
> +	i2c->irq = platform_get_irq(pdev, 0);
> +	if (i2c->irq < 0)
> +		return i2c->irq;
> +
> +	error = devm_request_irq(&pdev->dev, i2c->irq, zxi2c_isr,
> +			       IRQF_SHARED, pdev->name, i2c);

I took the freedom of re-alligning here.

Queued to i2c/i2c-host-fixes with Tested-by Hans.

Thanks,
Andi

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ