[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240626051832.axsmudzfkqvc5pb5@vireshk-i7>
Date: Wed, 26 Jun 2024 10:48:32 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Mario Limonciello <mario.limonciello@....com>
Cc: linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org,
"Gautham R . Shenoy" <gautham.shenoy@....com>,
Sibi Sankar <quic_sibis@...cinc.com>,
Dietmar Eggemann <dietmar.eggemann@....com>,
Dhruva Gole <d-gole@...com>, Yipeng Zou <zouyipeng@...wei.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>
Subject: Re: [PATCH 1/2] cpufreq: Allow drivers to advertise boost enabled
On 25-06-24, 23:11, Mario Limonciello wrote:
> The behavior introduced in commit f37a4d6b4a2c ("cpufreq: Fix per-policy
> boost behavior on SoCs using cpufreq_boost_set_sw()") sets up the boost
> policy incorrectly when boost has been enabled by the platform firmware
> initially even if a driver sets the policy up.
>
> This is because policy_has_boost_freq() assumes that there is a frequency
> table set up by the driver and that the boost frequencies are advertised
> in that table. This assumption doesn't work for acpi-cpufreq or
> amd-pstate. Only use this check to enable boost if it's not already
> enabled instead of also disabling it if alreayd enabled.
>
> Fixes: f37a4d6b4a2c ("cpufreq: Fix per-policy boost behavior on SoCs using cpufreq_boost_set_sw()")
> Suggested-by: Viresh Kumar <viresh.kumar@...aro.org>
> Suggested-by: Gautham R. Shenoy <gautham.shenoy@....com>
> Signed-off-by: Mario Limonciello <mario.limonciello@....com>
> ---
> Cc: Sibi Sankar <quic_sibis@...cinc.com>
> Cc: Dietmar Eggemann <dietmar.eggemann@....com>
> Cc: Viresh Kumar <viresh.kumar@...aro.org>
> Cc: Dhruva Gole <d-gole@...com>
> Cc: Yipeng Zou <zouyipeng@...wei.com>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> v14->v15:
> * Use Viresh's suggestion
> ---
> drivers/cpufreq/cpufreq.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 1fdabb660231..270ea04fb616 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1430,7 +1430,8 @@ static int cpufreq_online(unsigned int cpu)
> }
>
> /* Let the per-policy boost flag mirror the cpufreq_driver boost during init */
> - policy->boost_enabled = cpufreq_boost_enabled() && policy_has_boost_freq(policy);
> + if (cpufreq_boost_enabled() && policy_has_boost_freq(policy))
> + policy->boost_enabled = true;
>
> /*
> * The initialization has succeeded and the policy is online.
Acked-by: Viresh Kumar <viresh.kumar@...aro.org>
Rafael, this can go in to the next rc I believe (along with patch to
acpi-cpufreq).
--
viresh
Powered by blists - more mailing lists