linux-kernel - Re: [axboe-block:for-next] [block] bd4a633b6f: fsmark.files_per

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 14:11:11 +0800
From: Oliver Sang <oliver.sang@...el.com>
To: Christoph Hellwig <hch@....de>
CC: <oe-lkp@...ts.linux.dev>, <lkp@...el.com>, Jens Axboe <axboe@...nel.dk>,
	Damien Le Moal <dlemoal@...nel.org>, Hannes Reinecke <hare@...e.de>,
	<linux-m68k@...ts.linux-m68k.org>, <linux-um@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <linux-block@...r.kernel.org>,
	<drbd-dev@...ts.linbit.com>, <nbd@...er.debian.org>,
	<linuxppc-dev@...ts.ozlabs.org>, <ceph-devel@...r.kernel.org>,
	<virtualization@...ts.linux.dev>, <xen-devel@...ts.xenproject.org>,
	<linux-bcache@...r.kernel.org>, <dm-devel@...ts.linux.dev>,
	<linux-raid@...r.kernel.org>, <linux-mmc@...r.kernel.org>,
	<linux-mtd@...ts.infradead.org>, <nvdimm@...ts.linux.dev>,
	<linux-nvme@...ts.infradead.org>, <linux-s390@...r.kernel.org>,
	<linux-scsi@...r.kernel.org>, <ying.huang@...el.com>, <feng.tang@...el.com>,
	<fengwei.yin@...el.com>, <oliver.sang@...el.com>
Subject: Re: [axboe-block:for-next] [block]  bd4a633b6f: fsmark.files_per_sec
 -64.5% regression

hi, Christoph Hellwig,

On Mon, Jun 24, 2024 at 10:35:37AM +0200, Christoph Hellwig wrote:
> This is odd to say at least.  Any chance you can check the value
> of /sys/block/$DEVICE/queue/rotational for the relevant device before
> and after this commit?  And is this an ATA or NVMe SSD?
> 

yeah, as Niklas mentioned, it's an ATA SSD.

I checked the /sys/block/$DEVICE/queue/rotational before and after this commit,
both show '0'. not sure if this is expected.

anyway, I noticed you send a patch [1]

so I applied this patch upon bd4a633b6f, and found the performance restored.

=========================================================================================
compiler/cpufreq_governor/disk/filesize/fs2/fs/iterations/kconfig/nr_directories/nr_files_per_directory/nr_threads/rootfs/sync_method/tbox_group/test_size/testcase:
  gcc-13/performance/1SSD/9B/nfsv4/btrfs/1x/x86_64-rhel-8.3/16d/256fpd/32t/debian-12-x86_64-20240206.cgz/fsyncBeforeClose/lkp-ivb-2ep2/400M/fsmark

commit:
  1122c0c1cc ("block: move cache control settings out of queue->flags")
  bd4a633b6f ("block: move the nonrot flag to queue_limits")
  e9a0f6a398 = bd4a633b6f + patch [1]

1122c0c1cc71f740 bd4a633b6f7c3c6b6ebc1a07317 e9a0f6a398f162d115d208ad95b
---------------- --------------------------- ---------------------------
         %stddev     %change         %stddev     %change         %stddev
             \          |                \          |                \
      4177 ±  2%     -64.7%       1475            -1.1%       4130        fsmark.files_per_sec


[1] https://lore.kernel.org/all/20240624173835.76753-1-hch@lst.de/