linux-kernel - Re: [PATCH RFT v3 1/5] dt-bindings: media: camss: Add qcom,sc7180-camss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 14:46:32 +0800
From: george chan <gchan9527@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Robert Foss <rfoss@...nel.org>, Todor Tomov <todor.too@...il.com>, 
	"Bryan O'Donoghue" <bryan.odonoghue@...aro.org>, Mauro Carvalho Chehab <mchehab@...nel.org>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	cros-qcom-dts-watchers@...omium.org, Bjorn Andersson <andersson@...nel.org>, 
	Konrad Dybcio <konrad.dybcio@...aro.org>, linux-media@...r.kernel.org, 
	linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RFT v3 1/5] dt-bindings: media: camss: Add qcom,sc7180-camss

On Wed, Jun 26, 2024 at 2:12 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 24/06/2024 14:13, George Chan via B4 Relay wrote:
> > From: George Chan <gchan9527@...il.com>
> >
> > Add bindings for qcom,sc7180-camss in order to support the camera
> > subsystem for sm7125 as found in the Xiaomi Redmi 9 Pro cellphone.
>
>
> ...
>
> > +
> > +required:
> > +  - clock-names
> > +  - clocks
> > +  - compatible
>
> Nothing improved here.
>
> I asked you at v2 to go through all comments and respond to each of them
> or implement each of them.
>
>>> Keep the list ordered, the same as list properties.
I am a bit confused. Is it by ascending order or by particular order
like below the same ordering to the example node?
required:
  - compatible
  - reg
  - reg-names
  - clock-names
  - clocks

> BTW, I asked for subject to keep only one, first "media" prefix:
>         "Subject: just one media (first). "
> but you kept the second "media".

Sorry I can't get it. Could you choose one?

_ORIGINAL_
dt-bindings: media: camss: Add qcom,sc7180-camss

_PREFERED_
media: camss: dt-bindings: Add qcom,sc7180-camss

_OR_
dt-bindings: media: Add qcom,sc7180-camss

>
>
> Best regards,
> Krzysztof
>