[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<TY3PR01MB113464444BAE5D8B7B0CDD07A86D62@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Wed, 26 Jun 2024 06:47:22 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Laurent Pinchart <laurent.pinchart@...asonboard.com>, Prabhakar
<prabhakar.csengg@...il.com>
CC: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, David Airlie
<airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Maarten Lankhorst
<maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>,
Thomas Zimmermann <tzimmermann@...e.de>, Geert Uytterhoeven
<geert+renesas@...der.be>, "dri-devel@...ts.freedesktop.org"
<dri-devel@...ts.freedesktop.org>, "linux-renesas-soc@...r.kernel.org"
<linux-renesas-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, Fabrizio Castro
<fabrizio.castro.jz@...esas.com>, Prabhakar Mahadev Lad
<prabhakar.mahadev-lad.rj@...renesas.com>
Subject: RE: [PATCH] drm: renesas: Move RZ/G2L MIPI DSI driver to rz-du
Hi Laurent Pinchart,
> -----Original Message-----
> From: Laurent Pinchart <laurent.pinchart@...asonboard.com>
> Sent: Wednesday, June 26, 2024 6:51 AM
> Subject: Re: [PATCH] drm: renesas: Move RZ/G2L MIPI DSI driver to rz-du
>
> Hi Prabhakar,
>
> Thank you for the patch.
>
> On Tue, Jun 25, 2024 at 01:32:44PM +0100, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> >
> > All the RZ/G2L DU specific components are located under the rz-du
> > folder, so it makes sense to move the RZ/G2L MIPI DSI driver there
> > instead of keeping it in the rcar-du folder. This change improves the
> > organization and modularity of the driver configuration by grouping related settings together.
>
> I was thinking the same the other day. Thanks for beating me at sending a patch :-)
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>
>
> Do you or Biju has committer rights to drm-misc to push this patch ?
I guess, it will be taken by drm-misc folks like du driver, as this is now part of
rz-du folder which is part of the list [1] ??
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/MAINTAINERS?h=next-20240625#n7345
Cheers,
Biju
>
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > ---
> > drivers/gpu/drm/renesas/rcar-du/Kconfig | 8 --------
> > drivers/gpu/drm/renesas/rcar-du/Makefile | 2 --
> > drivers/gpu/drm/renesas/rz-du/Kconfig | 8 ++++++++
> > drivers/gpu/drm/renesas/rz-du/Makefile | 2 ++
> > .../gpu/drm/renesas/{rcar-du => rz-du}/rzg2l_mipi_dsi.c | 0
> > .../drm/renesas/{rcar-du => rz-du}/rzg2l_mipi_dsi_regs.h | 0
> > 6 files changed, 10 insertions(+), 10 deletions(-) rename
> > drivers/gpu/drm/renesas/{rcar-du => rz-du}/rzg2l_mipi_dsi.c (100%)
> > rename drivers/gpu/drm/renesas/{rcar-du =>
> > rz-du}/rzg2l_mipi_dsi_regs.h (100%)
> >
> > diff --git a/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > index 53c356aed5d5..39af73cf2092 100644
> > --- a/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > +++ b/drivers/gpu/drm/renesas/rcar-du/Kconfig
> > @@ -60,14 +60,6 @@ config DRM_RCAR_MIPI_DSI
> > select DRM_MIPI_DSI
> > select RESET_CONTROLLER
> >
> > -config DRM_RZG2L_MIPI_DSI
> > - tristate "RZ/G2L MIPI DSI Encoder Support"
> > - depends on DRM && DRM_BRIDGE && OF
> > - depends on ARCH_RENESAS || COMPILE_TEST
> > - select DRM_MIPI_DSI
> > - help
> > - Enable support for the RZ/G2L Display Unit embedded MIPI DSI encoders.
> > -
> > config DRM_RCAR_VSP
> > bool "R-Car DU VSP Compositor Support" if ARM
> > default y if ARM64
> > diff --git a/drivers/gpu/drm/renesas/rcar-du/Makefile
> > b/drivers/gpu/drm/renesas/rcar-du/Makefile
> > index b8f2c82651d9..6f132325c8b7 100644
> > --- a/drivers/gpu/drm/renesas/rcar-du/Makefile
> > +++ b/drivers/gpu/drm/renesas/rcar-du/Makefile
> > @@ -14,5 +14,3 @@ obj-$(CONFIG_DRM_RCAR_DU) += rcar-du-drm.o
> > obj-$(CONFIG_DRM_RCAR_DW_HDMI) += rcar_dw_hdmi.o
> > obj-$(CONFIG_DRM_RCAR_LVDS) += rcar_lvds.o
> > obj-$(CONFIG_DRM_RCAR_MIPI_DSI) += rcar_mipi_dsi.o
> > -
> > -obj-$(CONFIG_DRM_RZG2L_MIPI_DSI) += rzg2l_mipi_dsi.o
> > diff --git a/drivers/gpu/drm/renesas/rz-du/Kconfig
> > b/drivers/gpu/drm/renesas/rz-du/Kconfig
> > index 5f0db2c5fee6..8ec14271ebba 100644
> > --- a/drivers/gpu/drm/renesas/rz-du/Kconfig
> > +++ b/drivers/gpu/drm/renesas/rz-du/Kconfig
> > @@ -10,3 +10,11 @@ config DRM_RZG2L_DU
> > help
> > Choose this option if you have an RZ/G2L alike chipset.
> > If M is selected the module will be called rzg2l-du-drm.
> > +
> > +config DRM_RZG2L_MIPI_DSI
> > + tristate "RZ/G2L MIPI DSI Encoder Support"
> > + depends on DRM && DRM_BRIDGE && OF
> > + depends on ARCH_RENESAS || COMPILE_TEST
> > + select DRM_MIPI_DSI
> > + help
> > + Enable support for the RZ/G2L Display Unit embedded MIPI DSI encoders.
> > diff --git a/drivers/gpu/drm/renesas/rz-du/Makefile
> > b/drivers/gpu/drm/renesas/rz-du/Makefile
> > index 663b82a2577f..2987900ea6b6 100644
> > --- a/drivers/gpu/drm/renesas/rz-du/Makefile
> > +++ b/drivers/gpu/drm/renesas/rz-du/Makefile
> > @@ -6,3 +6,5 @@ rzg2l-du-drm-y := rzg2l_du_crtc.o \
> >
> > rzg2l-du-drm-$(CONFIG_VIDEO_RENESAS_VSP1) += rzg2l_du_vsp.o
> > obj-$(CONFIG_DRM_RZG2L_DU) += rzg2l-du-drm.o
> > +
> > +obj-$(CONFIG_DRM_RZG2L_MIPI_DSI) += rzg2l_mipi_dsi.o
> > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > similarity index 100%
> > rename from drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi.c
> > rename to drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi.c
> > diff --git a/drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi_regs.h
> > b/drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi_regs.h
> > similarity index 100%
> > rename from drivers/gpu/drm/renesas/rcar-du/rzg2l_mipi_dsi_regs.h
> > rename to drivers/gpu/drm/renesas/rz-du/rzg2l_mipi_dsi_regs.h
>
> --
> Regards,
>
> Laurent Pinchart
Powered by blists - more mailing lists