[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <293fb3d5-9b77-4321-8b31-d060cf96565d@kernel.org>
Date: Wed, 26 Jun 2024 11:22:57 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Shengjiu Wang <shengjiu.wang@....com>, lgirdwood@...il.com,
broonie@...nel.org, robh@...nel.org, krzk+dt@...nel.org,
conor+dt@...nel.org, shengjiu.wang@...il.com, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
shawnguo@...nel.org, s.hauer@...gutronix.de, kernel@...gutronix.de,
festevam@...il.com, imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: fsl,xcvr: Adjust the number of
interrupts
On 25/06/2024 06:56, Shengjiu Wang wrote:
> On i.MX8MP, there are 3 interrupts, the third interrupt is
> SPDIF wakeup interrupt from PHY
>
> Add ref: dai-common.yaml for #sound-dai-cells is needed and
> XCVR is a DAI device.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> ---
> Documentation/devicetree/bindings/sound/fsl,xcvr.yaml | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> index 197ae8ba9c30..7470866e11c6 100644
> --- a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> +++ b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> @@ -42,6 +42,7 @@ properties:
> items:
> - description: WAKEUPMIX Audio XCVR Interrupt 1
> - description: WAKEUPMIX Audio XCVR Interrupt 2
> + - description: SPDIF wakeup interrupt from PHY
> minItems: 1
>
> clocks:
> @@ -88,6 +89,7 @@ required:
> - dma-names
>
> allOf:
> + - $ref: dai-common.yaml#
> - if:
> properties:
> compatible:
> @@ -112,7 +114,7 @@ allOf:
> else:
> properties:
> interrupts:
> - maxItems: 1
> + maxItems: 3
I have doubts this was tested. The existing example should fail,
although I did not see any reports. Not sure why.
Best regards,
Krzysztof
Powered by blists - more mailing lists