[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAA+D8AMQv_=X3hC5uQbrDBN0EGo3U6EToGFVjUYcOVHpf5b=aQ@mail.gmail.com>
Date: Wed, 26 Jun 2024 17:25:53 +0800
From: Shengjiu Wang <shengjiu.wang@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Shengjiu Wang <shengjiu.wang@....com>, lgirdwood@...il.com, broonie@...nel.org,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 1/3] ASoC: dt-bindings: fsl,xcvr: Adjust the number of interrupts
On Wed, Jun 26, 2024 at 5:23 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 25/06/2024 06:56, Shengjiu Wang wrote:
> > On i.MX8MP, there are 3 interrupts, the third interrupt is
> > SPDIF wakeup interrupt from PHY
> >
> > Add ref: dai-common.yaml for #sound-dai-cells is needed and
> > XCVR is a DAI device.
> >
> > Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> > ---
> > Documentation/devicetree/bindings/sound/fsl,xcvr.yaml | 6 ++++--
> > 1 file changed, 4 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> > index 197ae8ba9c30..7470866e11c6 100644
> > --- a/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> > +++ b/Documentation/devicetree/bindings/sound/fsl,xcvr.yaml
> > @@ -42,6 +42,7 @@ properties:
> > items:
> > - description: WAKEUPMIX Audio XCVR Interrupt 1
> > - description: WAKEUPMIX Audio XCVR Interrupt 2
> > + - description: SPDIF wakeup interrupt from PHY
> > minItems: 1
> >
> > clocks:
> > @@ -88,6 +89,7 @@ required:
> > - dma-names
> >
> > allOf:
> > + - $ref: dai-common.yaml#
> > - if:
> > properties:
> > compatible:
> > @@ -112,7 +114,7 @@ allOf:
> > else:
> > properties:
> > interrupts:
> > - maxItems: 1
> > + maxItems: 3
>
> I have doubts this was tested. The existing example should fail,
> although I did not see any reports. Not sure why.
it is tested, because the minItems is 1. so the example can pass
Best regards
Shengjiu Wang
>
> Best regards,
> Krzysztof
>
Powered by blists - more mailing lists