linux-kernel - Re: [PATCH 1/2] ARM: 9258/1: Fix callchain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYAjKMSGmR4pc+LEfZ4NQArvgCEwy=ujzjOQus0K9j40w@mail.gmail.com>
Date: Wed, 26 Jun 2024 11:50:33 +0200
From: Linus Walleij <linus.walleij@...aro.org>
To: Jinjie Ruan <ruanjinjie@...wei.com>
Cc: linux@...linux.org.uk, will@...nel.org, mark.rutland@....com, 
	peterz@...radead.org, mingo@...hat.com, acme@...nel.org, namhyung@...nel.org, 
	alexander.shishkin@...ux.intel.com, jolsa@...nel.org, irogers@...gle.com, 
	adrian.hunter@...el.com, kan.liang@...ux.intel.com, arnd@...db.de, afd@...com, 
	akpm@...ux-foundation.org, rmk+kernel@...linux.org.uk, 
	eric.devolder@...cle.com, robh@...nel.org, ardb@...nel.org, 
	broonie@...nel.org, lihuafei1@...wei.com, 
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org, 
	linux-perf-users@...r.kernel.org
Subject: Re: [PATCH 1/2] ARM: 9258/1: Fix callchain_trace() return value

On Tue, Jun 18, 2024 at 5:23 AM Jinjie Ruan <ruanjinjie@...wei.com> wrote:

> perf_callchain_store() return 0 on success, -1 otherwise, fix
> callchain_trace() to return correct bool value. So walk_stackframe() can
> have a chance to stop walking the stack ahead.
>
> Fixes: 70ccc7c0667b ("ARM: 9258/1: stacktrace: Make stack walk callback consistent with generic code")
> Signed-off-by: Jinjie Ruan <ruanjinjie@...wei.com>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Please put this into Russell's patch tracker.

Yours,
Linus Walleij