[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ea452581-c903-4106-b912-d307f74f773d@lunn.ch>
Date: Thu, 27 Jun 2024 18:22:58 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for
aqr115c
On Thu, Jun 27, 2024 at 01:30:17PM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
>
> Add support for a new model to the Aquantia driver. This PHY supports
> Overlocked SGMII mode with 2.5G speeds.
>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> ---
> drivers/net/phy/aquantia/aquantia_main.c | 39 +++++++++++++++++++++++-
> 1 file changed, 38 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
> index 974795bd0860..98ccefd355d5 100644
> --- a/drivers/net/phy/aquantia/aquantia_main.c
> +++ b/drivers/net/phy/aquantia/aquantia_main.c
> @@ -29,6 +29,7 @@
> #define PHY_ID_AQR113 0x31c31c40
> #define PHY_ID_AQR113C 0x31c31c12
> #define PHY_ID_AQR114C 0x31c31c22
> +#define PHY_ID_AQR115C 0x31c31c33
> #define PHY_ID_AQR813 0x31c31cb2
>
> #define MDIO_PHYXS_VEND_IF_STATUS 0xe812
> @@ -111,7 +112,6 @@ static u64 aqr107_get_stat(struct phy_device *phydev, int index)
> int len_h = stat->size - len_l;
> u64 ret;
> int val;
> -
> val = phy_read_mmd(phydev, MDIO_MMD_C22EXT, stat->reg);
> if (val < 0)
> return U64_MAX;
White space change. And that blank line is actually wanted to separate
the variables from the code.
Andrew
---
pw-bot: cr
Powered by blists - more mailing lists