linux-kernel - Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMRc=Memf-fwY2iRXNDz7M4337PcH7quAZ7GHgjauj+Og8PwbQ@mail.gmail.com>
Date: Thu, 27 Jun 2024 18:48:51 +0200
From: Bartosz Golaszewski <brgl@...ev.pl>
To: Andrew Lunn <andrew@...n.ch>
Cc: Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, 
	"David S . Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
	linux-kernel@...r.kernel.org, 
	Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH v2 net-next 3/3] net: phy: aquantia: add support for aqr115c

On Thu, Jun 27, 2024 at 6:22 PM Andrew Lunn <andrew@...n.ch> wrote:
>
> On Thu, Jun 27, 2024 at 01:30:17PM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> >
> > Add support for a new model to the Aquantia driver. This PHY supports
> > Overlocked SGMII mode with 2.5G speeds.
> >
> > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
> > ---
> >  drivers/net/phy/aquantia/aquantia_main.c | 39 +++++++++++++++++++++++-
> >  1 file changed, 38 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/net/phy/aquantia/aquantia_main.c b/drivers/net/phy/aquantia/aquantia_main.c
> > index 974795bd0860..98ccefd355d5 100644
> > --- a/drivers/net/phy/aquantia/aquantia_main.c
> > +++ b/drivers/net/phy/aquantia/aquantia_main.c
> > @@ -29,6 +29,7 @@
> >  #define PHY_ID_AQR113        0x31c31c40
> >  #define PHY_ID_AQR113C       0x31c31c12
> >  #define PHY_ID_AQR114C       0x31c31c22
> > +#define PHY_ID_AQR115C       0x31c31c33
> >  #define PHY_ID_AQR813        0x31c31cb2
> >
> >  #define MDIO_PHYXS_VEND_IF_STATUS            0xe812
> > @@ -111,7 +112,6 @@ static u64 aqr107_get_stat(struct phy_device *phydev, int index)
> >       int len_h = stat->size - len_l;
> >       u64 ret;
> >       int val;
> > -
> >       val = phy_read_mmd(phydev, MDIO_MMD_C22EXT, stat->reg);
> >       if (val < 0)
> >               return U64_MAX;
>
> White space change. And that blank line is actually wanted to separate
> the variables from the code.
>

Ah, this is accidental, thanks for catching it.

Bart

>     Andrew
>
> ---
> pw-bot: cr