linux-kernel - Re: [PATCH v2 3/8] drm/tegra: Call drm_atomic_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D2ALRV4G5SZF.229WKTA9B95QN@gmail.com>
Date: Thu, 27 Jun 2024 08:58:13 +0200
From: "Thierry Reding" <thierry.reding@...il.com>
To: "Douglas Anderson" <dianders@...omium.org>,
 <dri-devel@...ts.freedesktop.org>, "Maxime Ripard" <mripard@...nel.org>
Cc: "Daniel Vetter" <daniel@...ll.ch>, "David Airlie" <airlied@...il.com>,
 "Jonathan Hunter" <jonathanh@...dia.com>, "Mikko Perttunen"
 <mperttunen@...dia.com>, <linux-kernel@...r.kernel.org>,
 <linux-tegra@...r.kernel.org>
Subject: Re: [PATCH v2 3/8] drm/tegra: Call drm_atomic_helper_shutdown() at
 shutdown time

On Thu Jun 13, 2024 at 12:23 AM CEST, Douglas Anderson wrote:
> Based on grepping through the source code this driver appears to be
> missing a call to drm_atomic_helper_shutdown() at system shutdown
> time. Among other things, this means that if a panel is in use that it
> won't be cleanly powered off at system shutdown time.
>
> The fact that we should call drm_atomic_helper_shutdown() in the case
> of OS shutdown/restart comes straight out of the kernel doc "driver
> instance overview" in drm_drv.c.
>
> Suggested-by: Maxime Ripard <mripard@...nel.org>
> Reviewed-by: Maxime Ripard <mripard@...nel.org>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> ---
> This commit is only compile-time tested.
>
> (no changes since v1)
>
>  drivers/gpu/drm/tegra/drm.c | 6 ++++++
>  1 file changed, 6 insertions(+)

Acked-by: Thierry Reding <treding@...dia.com>

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)