linux-kernel - Re: [PATCH 2/2] firmware: arm_scmi: set mailbox timeout value from device tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 10:59:16 +0800
From: kernel test robot <lkp@...el.com>
To: "Peng Fan (OSS)" <peng.fan@....nxp.com>,
	Sudeep Holla <sudeep.holla@....com>,
	Cristian Marussi <cristian.marussi@....com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, arm-scmi@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, Peng Fan <peng.fan@....com>
Subject: Re: [PATCH 2/2] firmware: arm_scmi: set mailbox timeout value from
 device tree

Hi Peng,

kernel test robot noticed the following build errors:

[auto build test ERROR on 76db4c64526c5e8ba0f56ad3d890dce8f9b00bbc]

url:    https://github.com/intel-lab-lkp/linux/commits/Peng-Fan-OSS/dt-bindings-firmware-arm-scmi-introduce-property-mbox-rx-timeout-ms/20240625-163117
base:   76db4c64526c5e8ba0f56ad3d890dce8f9b00bbc
patch link:    https://lore.kernel.org/r/20240621-scmi-mailbox-v1-v1-2-8ed450735f46%40nxp.com
patch subject: [PATCH 2/2] firmware: arm_scmi: set mailbox timeout value from device tree
config: i386-buildonly-randconfig-003-20240628 (https://download.01.org/0day-ci/archive/20240628/202406281000.agOs4t8T-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240628/202406281000.agOs4t8T-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406281000.agOs4t8T-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/firmware/arm_scmi/raw_mode.c: In function 'scmi_xfer_raw_waiter_enqueue':
>> drivers/firmware/arm_scmi/raw_mode.c:382:42: error: 'struct scmi_raw_mode_info' has no member named 'max_rx_timeout_ms'
     382 |                                       raw->max_rx_timeout_ms,
         |                                          ^~
   drivers/firmware/arm_scmi/raw_mode.c: In function 'scmi_xfer_raw_worker':
   drivers/firmware/arm_scmi/raw_mode.c:440:39: error: 'struct scmi_raw_mode_info' has no member named 'max_rx_timeout_ms'
     440 |         max_tmo = msecs_to_jiffies(raw->max_rx_timeout_ms);
         |                                       ^~
   drivers/firmware/arm_scmi/raw_mode.c: In function 'scmi_xfer_raw_get_init':
   drivers/firmware/arm_scmi/raw_mode.c:577:35: error: 'struct scmi_raw_mode_info' has no member named 'max_rx_timeout_ms'
     577 |                         msleep(raw->max_rx_timeout_ms /
         |                                   ^~
   drivers/firmware/arm_scmi/raw_mode.c: In function 'scmi_raw_mode_init':
   drivers/firmware/arm_scmi/raw_mode.c:1193:12: error: 'struct scmi_raw_mode_info' has no member named 'max_rx_timeout_ms'
    1193 |         raw->max_rx_timeout_ms = max_rx_timeout_ms;
         |            ^~


vim +382 drivers/firmware/arm_scmi/raw_mode.c

   372	
   373	static void scmi_xfer_raw_waiter_enqueue(struct scmi_raw_mode_info *raw,
   374						 struct scmi_xfer_raw_waiter *rw)
   375	{
   376		/* A timestamp for the deferred worker to know how much this has aged */
   377		rw->start_jiffies = jiffies;
   378	
   379		trace_scmi_xfer_response_wait(rw->xfer->transfer_id, rw->xfer->hdr.id,
   380					      rw->xfer->hdr.protocol_id,
   381					      rw->xfer->hdr.seq,
 > 382					      raw->max_rx_timeout_ms,
   383					      rw->xfer->hdr.poll_completion);
   384	
   385		mutex_lock(&raw->active_mtx);
   386		list_add_tail(&rw->node, &raw->active_waiters);
   387		mutex_unlock(&raw->active_mtx);
   388	
   389		/* kick waiter work */
   390		queue_work(raw->wait_wq, &raw->waiters_work);
   391	}
   392	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki