linux-kernel - Re: [PATCH v5 1/2] cros_ec_proto: Consolidate ec_response_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 11:00:49 +0800
From: Tzung-Bi Shih <tzungbi@...nel.org>
To: Daisuke Nojiri <dnojiri@...omium.org>
Cc: Benson Leung <bleung@...omium.org>, Guenter Roeck <groeck@...omium.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Reka Norman <rekanorman@...omium.org>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	Gwendal Grignou <gwendal@...omium.org>,
	Pavan Holla <pholla@...omium.org>,
	Lukasz Majczak <lma@...omium.org>,
	Ching-Kang Yen <chingkang@...omium.org>,
	Stephen Boyd <swboyd@...omium.org>,
	Prashant Malani <pmalani@...omium.org>,
	chrome-platform@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-input@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v5 1/2] cros_ec_proto: Consolidate
 ec_response_get_next_event

On Thu, Jun 27, 2024 at 04:53:07PM -0700, Daisuke Nojiri wrote:

Your previous patches have been applied to for-next branch:
ba098ed9829c ("platform/chrome: Add struct ec_response_get_next_event_v3")
106d67398233 ("platform/chrome: cros_ec_proto: Upgrade get_next_event to v3")

Please send incremental patches based on for-next.

> Consolidate struct ec_response_get_next_event_v*.
> 
> Let X->Y indicate kernel X sending EC_CMD_GET_NEXT_EVENT to FW Y.
> 
> Old->New:
>    Existing kernels send a smaller container (e.g.
>    ec_response_get_next_data) which may or may not fit the last few
>    bytes. The FW copies as many bytes as possible to the container. The
>    kernel processes as many leading bytes as it can understand.
> 
> New->Old:
>    New kernels send a bigger container. Existing FW copies as many bytes
>    as it wants, leaving the last few bytes empty. The kernel knows it
>    didn't receive full size data from the returned data length.
> 
> Signed-off-by: Daisuke Nojiri <dnojiri@...omium.org>
> ---
>  drivers/platform/chrome/cros_ec_proto.c       | 16 ++++-----
>  .../linux/platform_data/cros_ec_commands.h    | 34 +------------------

NACK, we don't do it: diverging cros_ec_commands.h and EC's ec_commands.h.