linux-kernel - Re: [PATCH V2] cpufreq: make cpufreq_boost

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 20:59:11 +0200
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Mario Limonciello <mario.limonciello@....com>, Dhruva Gole <d-gole@...com>
Cc: Viresh Kumar <viresh.kumar@...aro.org>, 
	"Rafael J . Wysocki" <rafael.j.wysocki@...el.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] cpufreq: make cpufreq_boost_enabled return bool

On Thu, Jun 27, 2024 at 8:57 PM Mario Limonciello
<mario.limonciello@....com> wrote:
>
> On 6/27/2024 01:01, Dhruva Gole wrote:
> > Since this function is supposed to return boost_enabled which is anyway
> > a bool type make sure that it's return value is also marked as bool.
> > This helps maintain better consistency in data types being used.
> >
> > Signed-off-by: Dhruva Gole <d-gole@...com>
>
> Reviewed-by: Mario Limonciello <mario.limonciello@....com>

Applied as 6.11 material, thanks!

> > ---
> >
> > Changelog:
> > "return false" instead of 0 as per Mario's suggestion.
> >
> > Link to previous patch:
> > https://lore.kernel.org/linux-pm/20240626084354.1762483-1-d-gole@ti.com/
> >
> > ---
> >
> >   drivers/cpufreq/cpufreq.c | 2 +-
> >   include/linux/cpufreq.h   | 6 +++---
> >   2 files changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> > index 82c500389a40..709e7b1f9826 100644
> > --- a/drivers/cpufreq/cpufreq.c
> > +++ b/drivers/cpufreq/cpufreq.c
> > @@ -2873,7 +2873,7 @@ int cpufreq_enable_boost_support(void)
> >   }
> >   EXPORT_SYMBOL_GPL(cpufreq_enable_boost_support);
> >
> > -int cpufreq_boost_enabled(void)
> > +bool cpufreq_boost_enabled(void)
> >   {
> >       return cpufreq_driver->boost_enabled;
> >   }
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index 20f7e98ee8af..6f57de7de433 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -785,7 +785,7 @@ ssize_t cpufreq_show_cpus(const struct cpumask *mask, char *buf);
> >
> >   #ifdef CONFIG_CPU_FREQ
> >   int cpufreq_boost_trigger_state(int state);
> > -int cpufreq_boost_enabled(void);
> > +bool cpufreq_boost_enabled(void);
> >   int cpufreq_enable_boost_support(void);
> >   bool policy_has_boost_freq(struct cpufreq_policy *policy);
> >
> > @@ -1164,9 +1164,9 @@ static inline int cpufreq_boost_trigger_state(int state)
> >   {
> >       return 0;
> >   }
> > -static inline int cpufreq_boost_enabled(void)
> > +static inline bool cpufreq_boost_enabled(void)
> >   {
> > -     return 0;
> > +     return false;
> >   }
> >
> >   static inline int cpufreq_enable_boost_support(void)
> >
> > base-commit: df9574a57d02b265322e77fb8628d4d33641dda9
>
>