linux-kernel - Re: [PATCH] PCI: fix recusive device locking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <667f13a334844_5639294d7@dwillia2-xfh.jf.intel.com.notmuch>
Date: Fri, 28 Jun 2024 12:48:51 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Keith Busch <kbusch@...a.com>, <linux-kernel@...r.kernel.org>,
	<bhelgaas@...gle.com>
CC: Keith Busch <kbusch@...nel.org>, Dan Williams <dan.j.williams@...el.com>,
	<linux-pci@...r.kernel.org>
Subject: Re: [PATCH] PCI: fix recusive device locking

[ add linux-pci ]

Keith Busch wrote:
> From: Keith Busch <kbusch@...nel.org>
> 
> If one of the bus' devices has subordinates, the recursive call locks
> itself, so no need to lock the device before the recusion or it will
> surely deadlock.
> 
> Fixes: dbc5b5c0d268f87 ("PCI: Add missing bridge lock to pci_bus_lock()"
> Cc: Dan Williams <dan.j.williams@...el.com>
> Signed-off-by: Keith Busch <kbusch@...nel.org>

Looks good, thanks for the fixup Keith!

Reviewed-by: Dan Williams <dan.j.williams@...el.com>