linux-kernel - Re: [PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 15:23:39 -0600
From: Mathieu Poirier <mathieu.poirier@...aro.org>
To: Richard Genoud <richard.genoud@...tlin.com>, Nishanth Menon <nm@...com>, 
	Vignesh Raghavendra <vigneshr@...com>, Hari Nagalla <hnagalla@...com>, "Andrew F. Davis" <afd@...com>
Cc: Bjorn Andersson <andersson@...nel.org>, Philipp Zabel <p.zabel@...gutronix.de>, 
	Suman Anna <s-anna@...com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Udit Kumar <u-kumar1@...com>, 
	Thomas Richard <thomas.richard@...tlin.com>, Gregory CLEMENT <gregory.clement@...tlin.com>, 
	Théo Lebrun <theo.lebrun@...tlin.com>, 
	linux-remoteproc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/4] remoteproc: k3-r5: Introduce suspend to ram support

On Fri, 21 Jun 2024 at 09:01, Richard Genoud <richard.genoud@...tlin.com> wrote:
>
> This series enables the suspend to ram with R5F remote processors on TI K3
> platform.
>
> The 1st patch is actually a fix, independent from the others
>
> The 2nd patch introduces the suspend/resume handlers.
> On suspend, the running rprocs will be stopped (or detached) and then
> re-loaded in resume.
> The logic behind this is:
>  - shutdown the cores that Linux started to save power in suspend.
>  - detach the cores that were started before Linux.
>
> Then, the 3rd and 4th patches introduce the graceful shutdown of remote
> procs. This will give them a chance to release resources and shut down
> in a civilized manner.
>
> Without this series, the suspend fails with:
>
> omap-mailbox 31f81000.mailbox: fifo 1 has unexpected unread messages
> omap-mailbox 31f81000.mailbox: PM: dpm_run_callback(): platform_pm_suspend returns -16
> omap-mailbox 31f81000.mailbox: PM: platform_pm_suspend returned -16 after 16328 usecs
> omap-mailbox 31f81000.mailbox: PM: failed to suspend: error -16
>
> Patches 2 and 4 are based on work from Hari Nagalla <hnagalla@...com>.
>
> @Hari, please feel free to add your Co-developed-by:/Signed-off-by:
>
> Tested on J7200X SoM
> Series is based on v6.10-rc4
>
> Richard Genoud (4):
>   remoteproc: k3-r5: Fix IPC-only mode detection
>   remoteproc: k3-r5: Introduce PM suspend/resume handlers
>   remoteproc: k3-r5: k3_r5_rproc_stop: code reorder
>   remoteproc: k3-r5: support for graceful stop of remote cores
>
>  drivers/remoteproc/omap_remoteproc.h     |   9 +-
>  drivers/remoteproc/ti_k3_r5_remoteproc.c | 196 +++++++++++++++++++++--
>  2 files changed, 188 insertions(+), 17 deletions(-)
>

Nishanth, Vignesh, Hari and Andrew - I will wait for you guys to
review this patch before moving forward.

Thanks,
Mathieu