linux-kernel - Re: [PATCH v22 09/18] x86/resctrl: Add a new field to struct rmid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0e47790-ea7d-41ac-ab69-d8dc0ec9f230@intel.com>
Date: Fri, 28 Jun 2024 14:51:42 -0700
From: Reinette Chatre <reinette.chatre@...el.com>
To: "Luck, Tony" <tony.luck@...el.com>, "Yu, Fenghua" <fenghua.yu@...el.com>,
	"Wieczor-Retman, Maciej" <maciej.wieczor-retman@...el.com>, Peter Newman
	<peternewman@...gle.com>, James Morse <james.morse@....com>, Babu Moger
	<babu.moger@....com>, Drew Fustini <dfustini@...libre.com>, Dave Martin
	<Dave.Martin@....com>
CC: "x86@...nel.org" <x86@...nel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "patches@...ts.linux.dev"
	<patches@...ts.linux.dev>
Subject: Re: [PATCH v22 09/18] x86/resctrl: Add a new field to struct
 rmid_read for summation of domains

Hi Tony,

On 6/28/24 2:35 PM, Luck, Tony wrote:
>> For example, something like below inserted at this point in changelog:
>>
>> 	The new semantics rely on some struct rmid_read members having
>> 	NULL values to distinguish between the SNC and non-SNC scenarios.
>> 	resctrl can thus no longer rely on this struct not being initialized
>> 	properly.
> 
> Just checking whether "resctrl" should be capitalized at the beginning of
> a sentence. Digging through logs there are half-a-dozen places where it
> got a "R" and three dozen where it didn't.

I am not familiar enough with language rules to know what is correct here.
Either should be fine. If I have to pick I'd vote for consistently
using resctrl without capitalization.

Reinette