| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202406281337.j4rbN9nr-lkp@intel.com>
Date: Fri, 28 Jun 2024 14:04:19 +0800
From: kernel test robot <lkp@...el.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: oe-kbuild-all@...ts.linux.dev, linux-media@...r.kernel.org,
Daniel Ferguson <danielf@...amperecomputing.com>,
"Rafael J. Wysocki" <rafael@...nel.org>,
Borislav Petkov <bp@...en8.de>,
Dan Williams <dan.j.williams@...el.com>,
Dave Jiang <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>,
James Morse <james.morse@....com>,
Jonathan Cameron <Jonathan.Cameron@...wei.com>,
Len Brown <lenb@...nel.org>, Shengwei Luo <luoshengwei@...wei.com>,
Shiju Jose <shiju.jose@...wei.com>,
Shuai Xue <xueshuai@...ux.alibaba.com>,
Tony Luck <tony.luck@...el.com>, linux-acpi@...r.kernel.org,
linux-edac@...r.kernel.org, linux-kernel@...r.kernel.org,
Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH 1/2] RAS: ACPI: APEI: add conditional compilation to ARM
error report functions
Hi Mauro,
kernel test robot noticed the following build errors:
[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.10-rc5 next-20240627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Mauro-Carvalho-Chehab/RAS-ACPI-APEI-add-conditional-compilation-to-ARM-error-report-functions/20240627-225843
base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link: https://lore.kernel.org/r/95baa46a5e1c88f08e328dbbfbbd01602e092234.1719471257.git.mchehab%2Bhuawei%40kernel.org
patch subject: [PATCH 1/2] RAS: ACPI: APEI: add conditional compilation to ARM error report functions
config: x86_64-randconfig-161-20240628 (https://download.01.org/0day-ci/archive/20240628/202406281337.j4rbN9nr-lkp@intel.com/config)
compiler: clang version 18.1.5 (https://github.com/llvm/llvm-project 617a15a9eac96088ae5e9134248d8236e34b91b1)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240628/202406281337.j4rbN9nr-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406281337.j4rbN9nr-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/acpi/apei/ghes.c:575:9: error: use of undeclared identifier 'queued'
575 | return queued;
| ^
1 error generated.
vim +/queued +575 drivers/acpi/apei/ghes.c
7f17b4a121d0d5 James Morse 2020-05-01 530
a70297d2213253 Shuai Xue 2023-12-18 531 static bool ghes_handle_arm_hw_error(struct acpi_hest_generic_data *gdata,
a70297d2213253 Shuai Xue 2023-12-18 532 int sev, bool sync)
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 533 {
4a485d7f807462 Daniel Ferguson 2024-06-27 534 #if defined(CONFIG_ARM) || defined (CONFIG_ARM64)
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 535 struct cper_sec_proc_arm *err = acpi_hest_get_payload(gdata);
a70297d2213253 Shuai Xue 2023-12-18 536 int flags = sync ? MF_ACTION_REQUIRED : 0;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 537 bool queued = false;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 538 int sec_sev, i;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 539 char *p;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 540
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 541 log_arm_hw_error(err);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 542
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 543 sec_sev = ghes_severity(gdata->error_severity);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 544 if (sev != GHES_SEV_RECOVERABLE || sec_sev != GHES_SEV_RECOVERABLE)
7f17b4a121d0d5 James Morse 2020-05-01 545 return false;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 546
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 547 p = (char *)(err + 1);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 548 for (i = 0; i < err->err_info_num; i++) {
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 549 struct cper_arm_err_info *err_info = (struct cper_arm_err_info *)p;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 550 bool is_cache = (err_info->type == CPER_ARM_CACHE_ERROR);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 551 bool has_pa = (err_info->validation_bits & CPER_ARM_INFO_VALID_PHYSICAL_ADDR);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 552 const char *error_type = "unknown error";
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 553
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 554 /*
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 555 * The field (err_info->error_info & BIT(26)) is fixed to set to
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 556 * 1 in some old firmware of HiSilicon Kunpeng920. We assume that
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 557 * firmware won't mix corrected errors in an uncorrected section,
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 558 * and don't filter out 'corrected' error here.
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 559 */
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 560 if (is_cache && has_pa) {
a70297d2213253 Shuai Xue 2023-12-18 561 queued = ghes_do_memory_failure(err_info->physical_fault_addr, flags);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 562 p += err_info->length;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 563 continue;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 564 }
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 565
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 566 if (err_info->type < ARRAY_SIZE(cper_proc_error_type_strs))
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 567 error_type = cper_proc_error_type_strs[err_info->type];
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 568
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 569 pr_warn_ratelimited(FW_WARN GHES_PFX
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 570 "Unhandled processor error type: %s\n",
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 571 error_type);
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 572 p += err_info->length;
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 573 }
4a485d7f807462 Daniel Ferguson 2024-06-27 574 #endif
ccb5ecdc2ddeaf Xiaofei Tan 2021-06-11 @575 return queued;
cf870c70a19444 Naveen N. Rao 2013-07-10 576 }
cf870c70a19444 Naveen N. Rao 2013-07-10 577
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists