linux-kernel - Re: [PATCH 2/2] RAS: Report all ARM processor CPER information to userspace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202406281751.Wuf4JcIZ-lkp@intel.com>
Date: Fri, 28 Jun 2024 17:52:50 +0800
From: kernel test robot <lkp@...el.com>
To: Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-media@...r.kernel.org, Shengwei Luo <luoshengwei@...wei.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Borislav Petkov <bp@...en8.de>,
	Dan Williams <dan.j.williams@...el.com>,
	Daniel Ferguson <danielf@...amperecomputing.com>,
	Dave Jiang <dave.jiang@...el.com>, Ira Weiny <ira.weiny@...el.com>,
	James Morse <james.morse@....com>,
	Jonathan Cameron <Jonathan.Cameron@...wei.com>,
	Len Brown <lenb@...nel.org>, Shiju Jose <shiju.jose@...wei.com>,
	Shuai Xue <xueshuai@...ux.alibaba.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Tony Luck <tony.luck@...el.com>,
	Tyler Baicar <tbaicar@...eaurora.org>,
	Will Deacon <will@...nel.org>, Xie XiuQi <xiexiuqi@...wei.com>,
	linux-acpi@...r.kernel.org, linux-edac@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Jason Tian <jason@...amperecomputing.com>,
	Mauro Carvalho Chehab <mchehab@...nel.org>
Subject: Re: [PATCH 2/2] RAS: Report all ARM processor CPER information to
 userspace

Hi Mauro,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v6.10-rc5 next-20240627]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mauro-Carvalho-Chehab/RAS-ACPI-APEI-add-conditional-compilation-to-ARM-error-report-functions/20240627-225843
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/eed2c4a4fbbb71226ca1944bc7e319bfa9f8aec0.1719471257.git.mchehab%2Bhuawei%40kernel.org
patch subject: [PATCH 2/2] RAS: Report all ARM processor CPER information to userspace
config: arm64-randconfig-003-20240628 (https://download.01.org/0day-ci/archive/20240628/202406281751.Wuf4JcIZ-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 326ba38a991250a8587a399a260b0f7af2c9166a)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240628/202406281751.Wuf4JcIZ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406281751.Wuf4JcIZ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/ras/ras.c:46:
   In file included from include/ras/ras_event.h:12:
   In file included from include/linux/pci.h:1650:
   In file included from include/linux/dmapool.h:14:
   In file included from include/linux/scatterlist.h:8:
   In file included from include/linux/mm.h:2253:
   include/linux/vmstat.h:514:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     514 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
>> drivers/ras/ras.c:73:10: error: incompatible pointer types assigning to 'u8 *' (aka 'unsigned char *') from 'struct cper_arm_ctx_info *' [-Werror,-Wincompatible-pointer-types]
      73 |         ctx_err = ctx_info;
         |                 ^ ~~~~~~~~
   1 warning and 1 error generated.


vim +73 drivers/ras/ras.c

    54	
    55	void log_arm_hw_error(struct cper_sec_proc_arm *err, const u8 sev)
    56	{
    57	#if defined(CONFIG_ARM) || defined(CONFIG_ARM64)
    58		struct cper_arm_err_info *err_info;
    59		struct cper_arm_ctx_info *ctx_info;
    60		u8 *ven_err_data;
    61		u32 ctx_len = 0;
    62		int n, sz, cpu;
    63		s32 vsei_len;
    64		u32 pei_len;
    65		u8 *pei_err;
    66		u8 *ctx_err;
    67	
    68		pei_len = sizeof(struct cper_arm_err_info) * err->err_info_num;
    69		pei_err = (u8 *)err + sizeof(struct cper_sec_proc_arm);
    70	
    71		err_info = (struct cper_arm_err_info *)(err + 1);
    72		ctx_info = (struct cper_arm_ctx_info *)(err_info + err->err_info_num);
  > 73		ctx_err = ctx_info;
    74		for (n = 0; n < err->context_info_num; n++) {
    75			sz = sizeof(struct cper_arm_ctx_info) + ctx_info->size;
    76			ctx_info = (struct cper_arm_ctx_info *)((long)ctx_info + sz);
    77			ctx_len += sz;
    78		}
    79	
    80		vsei_len = err->section_length - (sizeof(struct cper_sec_proc_arm) +
    81						  pei_len + ctx_len);
    82		if (vsei_len < 0) {
    83			pr_warn(FW_BUG
    84				"section length: %d\n", err->section_length);
    85			pr_warn(FW_BUG
    86				"section length is too small\n");
    87			pr_warn(FW_BUG
    88				"firmware-generated error record is incorrect\n");
    89			vsei_len = 0;
    90		}
    91		ven_err_data = (u8 *)ctx_info;
    92	
    93		cpu = GET_LOGICAL_INDEX(err->mpidr);
    94		/* when return value is invalid, set cpu index to -1 */
    95		if (cpu < 0)
    96			cpu = -1;
    97	
    98		trace_arm_event(err, pei_err, pei_len, ctx_err, ctx_len,
    99				ven_err_data, (u32)vsei_len, sev, cpu);
   100	#endif
   101	}
   102	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki