linux-kernel - Re: [PATCH v4 0/9] Add Mule MFD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Fri, 28 Jun 2024 11:03:51 +0200
From: Farouk Bouabid <farouk.bouabid@...rry.de>
To: Guenter Roeck <linux@...ck-us.net>,
 Quentin Schulz <quentin.schulz@...rry.de>, Jean Delvare <jdelvare@...e.com>,
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>,
 Peter Rosin <peda@...ntia.se>, Heiko Stuebner <heiko@...ech.de>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: Re: [PATCH v4 0/9] Add Mule MFD support

Hi Guenter,

On 28.06.24 02:05, Guenter Roeck wrote:
> On 6/24/24 09:13, Farouk Bouabid wrote:
>> Hi Guenter,
>>
>> On 19.06.24 15:31, Guenter Roeck wrote:
>>> On 6/19/24 00:45, Farouk Bouabid wrote:


[...]


>
>> If we cannot proceed with that then we could add a compatible to the 
>> amc6821 driver to add the mux device (Basically the "tsd,mule" 
>> compatible in amc6821 compatible list would be a combo driver with 
>> mux logic + amc6821). Do you think that is more appropriate ?
>>
>
> Implement the mux as part of the amc6821 driver ? No. We could discuss
> instantiating the i2c mux driver from the amc6821 driver.


If I understand correctly we would have the amc6821 for "tsd,mule" 
compatible probe the mule-i2c-mux as platform_device. Possible DT 
representation would be something like:


i2c {
     #address-cells = <1>;
     #size-cells = <0>;

     fan@18 {
         compatible = "tsd,mule", "ti,amc6821";
         reg = <0x18>;

         i2c-mux {
             compatible = "tsd,mule-i2c-mux";
             #address-cells = <1>;
             #size-cells = <0>;

             i2c@0 {
                 reg = <0x0>;
                 #address-cells = <1>;
                 #size-cells = <0>;

                 rtc@6f {
                     compatible = "isil,isl1208";
                     reg = <0x6f>;
                 };

             };
         };
     };
};


Cheers,

Farouk