linux-kernel - Re: [PATCH v2 0/2] PCI: microchip: support using either instance 1 or 2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zn58pDsX5YZL/pTD@daire-X570>
Date: Fri, 28 Jun 2024 10:04:36 +0100
From: Daire McNamara <daire.mcnamara@...rochip.com>
To: Conor Dooley <conor@...nel.org>
CC: <linux-pci@...r.kernel.org>, Conor Dooley <conor.dooley@...rochip.com>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>, Krzysztof
 Wilczyński <kw@...ux.com>, Rob Herring <robh@...nel.org>,
	Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
	<devicetree@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<linux-riscv@...ts.infradead.org>
Subject: Re: [PATCH v2 0/2] PCI: microchip: support using either instance 1
 or 2

With the proviso of fixing the axi_/apb_ nit

Acked-by: Daire McNamara <daire.mcnamara@...rochip.com>

On Wed, Jun 12, 2024 at 11:57:54AM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> The current driver and binding for PolarFire SoC's PCI controller assume
> that the root port instance in use is instance 1. The second reg
> property constitutes the region encompassing both "control" and "bridge"
> registers for both instances. In the driver, a fixed offset is applied to
> find the base addresses for instance 1's "control" and "bridge"
> registers. The BeagleV Fire uses root port instance 2, so something must
> be done so that software can differentiate. This series splits the
> second reg property in two, with dedicated "control" and "bridge"
> entries so that either instance can be used.
> 
> Cheers,
> Conor.
> 
> v2:
> - try the new reg format before the old one to avoid warnings in the
>   new case
> - reword $subject for 2/2
> 
> CC: Daire McNamara <daire.mcnamara@...rochip.com>
> CC: Lorenzo Pieralisi <lpieralisi@...nel.org>
> CC: Krzysztof Wilczyński <kw@...ux.com>
> CC: Rob Herring <robh@...nel.org>
> CC: Bjorn Helgaas <bhelgaas@...gle.com>
> CC: Krzysztof Kozlowski <krzk+dt@...nel.org>
> CC: Conor Dooley <conor+dt@...nel.org>
> CC: linux-pci@...r.kernel.org
> CC: devicetree@...r.kernel.org
> CC: linux-kernel@...r.kernel.org
> CC: linux-riscv@...ts.infradead.org
> 
> Conor Dooley (2):
>   dt-bindings: PCI: microchip,pcie-host: fix reg properties
>   PCI: microchip: rework reg region handing to support using either
>     instance 1 or 2
> 
>  .../bindings/pci/microchip,pcie-host.yaml     |  10 +-
>  drivers/pci/controller/pcie-microchip-host.c  | 155 +++++++++---------
>  2 files changed, 79 insertions(+), 86 deletions(-)
> 
> -- 
> 2.43.0
> 
>