linux-kernel - Re: [PATCH net-next v15 02/14] net: netdev netlink api to bind dma-buf to a net device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m27ce9cris.fsf@gmail.com>
Date: Fri, 28 Jun 2024 11:04:27 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-doc@...r.kernel.org,  linux-alpha@...r.kernel.org,
  linux-mips@...r.kernel.org,  linux-parisc@...r.kernel.org,
  sparclinux@...r.kernel.org,  linux-trace-kernel@...r.kernel.org,
  linux-arch@...r.kernel.org,  bpf@...r.kernel.org,
  linux-kselftest@...r.kernel.org,  linux-media@...r.kernel.org,
  dri-devel@...ts.freedesktop.org,  "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Jakub
 Kicinski <kuba@...nel.org>,  Paolo Abeni <pabeni@...hat.com>,  Jonathan
 Corbet <corbet@....net>,  Richard Henderson
 <richard.henderson@...aro.org>,  Ivan Kokshaysky
 <ink@...assic.park.msu.ru>,  Matt Turner <mattst88@...il.com>,  Thomas
 Bogendoerfer <tsbogend@...ha.franken.de>,  "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>,  Helge Deller <deller@....de>,
  Andreas Larsson <andreas@...sler.com>,  Jesper Dangaard Brouer
 <hawk@...nel.org>,  Ilias Apalodimas <ilias.apalodimas@...aro.org>,
  Steven Rostedt <rostedt@...dmis.org>,  Masami Hiramatsu
 <mhiramat@...nel.org>,  Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>,  Arnd Bergmann <arnd@...db.de>,  Alexei
 Starovoitov <ast@...nel.org>,  Daniel Borkmann <daniel@...earbox.net>,
  Andrii Nakryiko <andrii@...nel.org>,  Martin KaFai Lau
 <martin.lau@...ux.dev>,  Eduard Zingerman <eddyz87@...il.com>,  Song Liu
 <song@...nel.org>,  Yonghong Song <yonghong.song@...ux.dev>,  John
 Fastabend <john.fastabend@...il.com>,  KP Singh <kpsingh@...nel.org>,
  Stanislav Fomichev <sdf@...ichev.me>,  Hao Luo <haoluo@...gle.com>,  Jiri
 Olsa <jolsa@...nel.org>,  Steffen Klassert <steffen.klassert@...unet.com>,
  Herbert Xu <herbert@...dor.apana.org.au>,  David Ahern
 <dsahern@...nel.org>,  Willem de Bruijn <willemdebruijn.kernel@...il.com>,
  Shuah Khan <shuah@...nel.org>,  Sumit Semwal <sumit.semwal@...aro.org>,
  Christian König <christian.koenig@....com>,  Bagas
 Sanjaya
 <bagasdotme@...il.com>,  Christoph Hellwig <hch@...radead.org>,  Nikolay
 Aleksandrov <razor@...ckwall.org>,  Pavel Begunkov
 <asml.silence@...il.com>,  David Wei <dw@...idwei.uk>,  Jason Gunthorpe
 <jgg@...pe.ca>,  Yunsheng Lin <linyunsheng@...wei.com>,  Shailend Chand
 <shailend@...gle.com>,  Harshitha Ramamurthy <hramamurthy@...gle.com>,
  Shakeel Butt <shakeel.butt@...ux.dev>,  Jeroen de Borst
 <jeroendb@...gle.com>,  Praveen Kaligineedi <pkaligineedi@...gle.com>,
  Stanislav Fomichev <sdf@...gle.com>
Subject: Re: [PATCH net-next v15 02/14] net: netdev netlink api to bind
 dma-buf to a net device

Mina Almasry <almasrymina@...gle.com> writes:
> +  -
> +    name: bind-dmabuf
> +    attributes:
> +      -
> +        name: ifindex
> +        doc: netdev ifindex to bind the dma-buf to.

Minor nit:

The series uses a mix of dmabuf and dma-buf but the doc additions
(devmem.rst) consistently uses dmabuf. I think it would be helpful to be
consistent here and say 'devmem dmabuf' in the docstring to highlight
whos dmabuf it is and keep the generated netdev docs in alignment.

> +        type: u32
> +        checks:
> +          min: 1
> +      -
> +        name: queues
> +        doc: receive queues to bind the dma-buf to.

And here.

> +        type: nest
> +        nested-attributes: queue-dmabuf
> +        multi-attr: true
> +      -
> +        name: dmabuf-fd
> +        doc: dmabuf file descriptor to bind.
> +        type: u32
> +      -
> +        name: dmabuf-id
> +        doc: id of the dmabuf binding
> +        type: u32
> +        checks:
> +          min: 1
> +
>  
>    -
>      name: qstats
> @@ -579,6 +618,20 @@ operations:
>            attributes:
>              - ifindex
>          reply: *queue-get-op
> +    -
> +      name: bind-rx
> +      doc: Bind dmabuf to netdev

And here.

> +      attribute-set: bind-dmabuf
> +      flags: [ admin-perm ]
> +      do:
> +        request:
> +          attributes:
> +            - ifindex
> +            - dmabuf-fd
> +            - queues
> +        reply:
> +          attributes:
> +            - dmabuf-id