linux-kernel - Re: [PATCH net-next v15 12/14] net: add devmem TCP documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m234oxcraf.fsf@gmail.com>
Date: Fri, 28 Jun 2024 11:09:28 +0100
From: Donald Hunter <donald.hunter@...il.com>
To: Mina Almasry <almasrymina@...gle.com>
Cc: netdev@...r.kernel.org,  linux-kernel@...r.kernel.org,
  linux-doc@...r.kernel.org,  linux-alpha@...r.kernel.org,
  linux-mips@...r.kernel.org,  linux-parisc@...r.kernel.org,
  sparclinux@...r.kernel.org,  linux-trace-kernel@...r.kernel.org,
  linux-arch@...r.kernel.org,  bpf@...r.kernel.org,
  linux-kselftest@...r.kernel.org,  linux-media@...r.kernel.org,
  dri-devel@...ts.freedesktop.org,  "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Jakub
 Kicinski <kuba@...nel.org>,  Paolo Abeni <pabeni@...hat.com>,  Jonathan
 Corbet <corbet@....net>,  Richard Henderson
 <richard.henderson@...aro.org>,  Ivan Kokshaysky
 <ink@...assic.park.msu.ru>,  Matt Turner <mattst88@...il.com>,  Thomas
 Bogendoerfer <tsbogend@...ha.franken.de>,  "James E.J. Bottomley"
 <James.Bottomley@...senPartnership.com>,  Helge Deller <deller@....de>,
  Andreas Larsson <andreas@...sler.com>,  Jesper Dangaard Brouer
 <hawk@...nel.org>,  Ilias Apalodimas <ilias.apalodimas@...aro.org>,
  Steven Rostedt <rostedt@...dmis.org>,  Masami Hiramatsu
 <mhiramat@...nel.org>,  Mathieu Desnoyers
 <mathieu.desnoyers@...icios.com>,  Arnd Bergmann <arnd@...db.de>,  Alexei
 Starovoitov <ast@...nel.org>,  Daniel Borkmann <daniel@...earbox.net>,
  Andrii Nakryiko <andrii@...nel.org>,  Martin KaFai Lau
 <martin.lau@...ux.dev>,  Eduard Zingerman <eddyz87@...il.com>,  Song Liu
 <song@...nel.org>,  Yonghong Song <yonghong.song@...ux.dev>,  John
 Fastabend <john.fastabend@...il.com>,  KP Singh <kpsingh@...nel.org>,
  Stanislav Fomichev <sdf@...ichev.me>,  Hao Luo <haoluo@...gle.com>,  Jiri
 Olsa <jolsa@...nel.org>,  Steffen Klassert <steffen.klassert@...unet.com>,
  Herbert Xu <herbert@...dor.apana.org.au>,  David Ahern
 <dsahern@...nel.org>,  Willem de Bruijn <willemdebruijn.kernel@...il.com>,
  Shuah Khan <shuah@...nel.org>,  Sumit Semwal <sumit.semwal@...aro.org>,
  Christian König <christian.koenig@....com>,  Bagas
 Sanjaya
 <bagasdotme@...il.com>,  Christoph Hellwig <hch@...radead.org>,  Nikolay
 Aleksandrov <razor@...ckwall.org>,  Pavel Begunkov
 <asml.silence@...il.com>,  David Wei <dw@...idwei.uk>,  Jason Gunthorpe
 <jgg@...pe.ca>,  Yunsheng Lin <linyunsheng@...wei.com>,  Shailend Chand
 <shailend@...gle.com>,  Harshitha Ramamurthy <hramamurthy@...gle.com>,
  Shakeel Butt <shakeel.butt@...ux.dev>,  Jeroen de Borst
 <jeroendb@...gle.com>,  Praveen Kaligineedi <pkaligineedi@...gle.com>
Subject: Re: [PATCH net-next v15 12/14] net: add devmem TCP documentation

Mina Almasry <almasrymina@...gle.com> writes:
> +
> +The user must bind a dmabuf to any number of RX queues on a given NIC using
> +the netlink API::
> +
> +	/* Bind dmabuf to NIC RX queue 15 */
> +	struct netdev_queue *queues;
> +	queues = malloc(sizeof(*queues) * 1);
> +
> +	queues[0]._present.type = 1;
> +	queues[0]._present.idx = 1;
> +	queues[0].type = NETDEV_RX_QUEUE_TYPE_RX;
> +	queues[0].idx = 15;
> +
> +	*ys = ynl_sock_create(&ynl_netdev_family, &yerr);
> +
> +	req = netdev_bind_rx_req_alloc();
> +	netdev_bind_rx_req_set_ifindex(req, 1 /* ifindex */);
> +	netdev_bind_rx_req_set_dmabuf_fd(req, dmabuf_fd);
> +	__netdev_bind_rx_req_set_queues(req, queues, n_queue_index);
> +
> +	rsp = netdev_bind_rx(*ys, req);
> +
> +	dmabuf_id = rsp->dmabuf_id;
> +
> +
> +The netlink API returns a dmabuf_id: a unique ID that refers to this dmabuf
> +that has been bound.

The docs don't mention the unbinding behaviour. Can you add the text
from the commit message for patch 3 ?