| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 29 Jun 2024 21:55:03 +0800
From: kernel test robot <lkp@...el.com>
To: Breno Leitao <leitao@...ian.org>, linuxppc-dev@...ts.ozlabs.org,
linux-arm-kernel@...ts.infradead.org, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, kuba@...nel.org, horms@...nel.org,
Roy.Pledge@....com, open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST
Hi Breno,
kernel test robot noticed the following build warnings:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master soc/for-next linus/master v6.10-rc5 next-20240628]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Breno-Leitao/crypto-caam-Depend-on-COMPILE_TEST-also/20240625-223834
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/20240624162128.1665620-1-leitao%40debian.org
patch subject: [PATCH 1/4] soc: fsl: qbman: FSL_DPAA depends on COMPILE_TEST
config: sparc-allmodconfig
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406292113.eqOGC5ek-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/net/ethernet/freescale/dpaa/dpaa_eth.c: In function 'dpaa_fq_setup.constprop':
>> drivers/net/ethernet/freescale/dpaa/dpaa_eth.c:1000:1: warning: the frame size of 8192 bytes is larger than 2048 bytes [-Wframe-larger-than=]
1000 | }
| ^
--
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c: In function 'dpaa_get_strings':
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:257:64: warning: '%s' directive output may be truncated writing up to 287 bytes into a region of size 32 [-Wformat-truncation=]
257 | snprintf(string_cpu, ETH_GSTRING_LEN, "%s [CPU %d]",
| ^~
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:257:63: note: using the range [-2147483648, 2147483647] for directive argument
257 | snprintf(string_cpu, ETH_GSTRING_LEN, "%s [CPU %d]",
| ^~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:257:25: note: 'snprintf' output between 9 and 306 bytes into a destination of size 32
257 | snprintf(string_cpu, ETH_GSTRING_LEN, "%s [CPU %d]",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
258 | dpaa_stats_percpu[i], j);
| ~~~~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:262:56: warning: '%s' directive output may be truncated writing up to 287 bytes into a region of size 32 [-Wformat-truncation=]
262 | snprintf(string_cpu, ETH_GSTRING_LEN, "%s [TOTAL]",
| ^~
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:262:17: note: 'snprintf' output between 9 and 296 bytes into a destination of size 32
262 | snprintf(string_cpu, ETH_GSTRING_LEN, "%s [TOTAL]",
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
263 | dpaa_stats_percpu[i]);
| ~~~~~~~~~~~~~~~~~~~~~
drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c: In function 'dpaa_set_coalesce':
>> drivers/net/ethernet/freescale/dpaa/dpaa_ethtool.c:502:1: warning: the frame size of 4112 bytes is larger than 2048 bytes [-Wframe-larger-than=]
502 | }
| ^
vim +1000 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
9ad1a37493338c Madalin Bucur 2016-11-15 933
9ad1a37493338c Madalin Bucur 2016-11-15 934 static void dpaa_fq_setup(struct dpaa_priv *priv,
9ad1a37493338c Madalin Bucur 2016-11-15 935 const struct dpaa_fq_cbs *fq_cbs,
9ad1a37493338c Madalin Bucur 2016-11-15 936 struct fman_port *tx_port)
9ad1a37493338c Madalin Bucur 2016-11-15 937 {
3150b7c20b8628 Madalin Bucur 2017-08-27 938 int egress_cnt = 0, conf_cnt = 0, num_portals = 0, portal_cnt = 0, cpu;
9ad1a37493338c Madalin Bucur 2016-11-15 939 const cpumask_t *affine_cpus = qman_affine_cpus();
3150b7c20b8628 Madalin Bucur 2017-08-27 940 u16 channels[NR_CPUS];
9ad1a37493338c Madalin Bucur 2016-11-15 941 struct dpaa_fq *fq;
9ad1a37493338c Madalin Bucur 2016-11-15 942
7aae703f8096d2 Madalin Bucur 2019-05-27 943 for_each_cpu_and(cpu, affine_cpus, cpu_online_mask)
3150b7c20b8628 Madalin Bucur 2017-08-27 944 channels[num_portals++] = qman_affine_channel(cpu);
3150b7c20b8628 Madalin Bucur 2017-08-27 945
9ad1a37493338c Madalin Bucur 2016-11-15 946 if (num_portals == 0)
9ad1a37493338c Madalin Bucur 2016-11-15 947 dev_err(priv->net_dev->dev.parent,
6e6583c91f9479 Madalin Bucur 2019-10-23 948 "No Qman software (affine) channels found\n");
9ad1a37493338c Madalin Bucur 2016-11-15 949
9ad1a37493338c Madalin Bucur 2016-11-15 950 /* Initialize each FQ in the list */
9ad1a37493338c Madalin Bucur 2016-11-15 951 list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
9ad1a37493338c Madalin Bucur 2016-11-15 952 switch (fq->fq_type) {
9ad1a37493338c Madalin Bucur 2016-11-15 953 case FQ_TYPE_RX_DEFAULT:
9ad1a37493338c Madalin Bucur 2016-11-15 954 dpaa_setup_ingress(priv, fq, &fq_cbs->rx_defq);
9ad1a37493338c Madalin Bucur 2016-11-15 955 break;
9ad1a37493338c Madalin Bucur 2016-11-15 956 case FQ_TYPE_RX_ERROR:
9ad1a37493338c Madalin Bucur 2016-11-15 957 dpaa_setup_ingress(priv, fq, &fq_cbs->rx_errq);
9ad1a37493338c Madalin Bucur 2016-11-15 958 break;
3150b7c20b8628 Madalin Bucur 2017-08-27 959 case FQ_TYPE_RX_PCD:
3150b7c20b8628 Madalin Bucur 2017-08-27 960 if (!num_portals)
3150b7c20b8628 Madalin Bucur 2017-08-27 961 continue;
3150b7c20b8628 Madalin Bucur 2017-08-27 962 dpaa_setup_ingress(priv, fq, &fq_cbs->rx_defq);
3150b7c20b8628 Madalin Bucur 2017-08-27 963 fq->channel = channels[portal_cnt++ % num_portals];
3150b7c20b8628 Madalin Bucur 2017-08-27 964 break;
9ad1a37493338c Madalin Bucur 2016-11-15 965 case FQ_TYPE_TX:
9ad1a37493338c Madalin Bucur 2016-11-15 966 dpaa_setup_egress(priv, fq, tx_port,
9ad1a37493338c Madalin Bucur 2016-11-15 967 &fq_cbs->egress_ern);
9ad1a37493338c Madalin Bucur 2016-11-15 968 /* If we have more Tx queues than the number of cores,
9ad1a37493338c Madalin Bucur 2016-11-15 969 * just ignore the extra ones.
9ad1a37493338c Madalin Bucur 2016-11-15 970 */
9ad1a37493338c Madalin Bucur 2016-11-15 971 if (egress_cnt < DPAA_ETH_TXQ_NUM)
9ad1a37493338c Madalin Bucur 2016-11-15 972 priv->egress_fqs[egress_cnt++] = &fq->fq_base;
9ad1a37493338c Madalin Bucur 2016-11-15 973 break;
9ad1a37493338c Madalin Bucur 2016-11-15 974 case FQ_TYPE_TX_CONF_MQ:
9ad1a37493338c Madalin Bucur 2016-11-15 975 priv->conf_fqs[conf_cnt++] = &fq->fq_base;
df561f6688fef7 Gustavo A. R. Silva 2020-08-23 976 fallthrough;
9ad1a37493338c Madalin Bucur 2016-11-15 977 case FQ_TYPE_TX_CONFIRM:
9ad1a37493338c Madalin Bucur 2016-11-15 978 dpaa_setup_ingress(priv, fq, &fq_cbs->tx_defq);
9ad1a37493338c Madalin Bucur 2016-11-15 979 break;
9ad1a37493338c Madalin Bucur 2016-11-15 980 case FQ_TYPE_TX_ERROR:
9ad1a37493338c Madalin Bucur 2016-11-15 981 dpaa_setup_ingress(priv, fq, &fq_cbs->tx_errq);
9ad1a37493338c Madalin Bucur 2016-11-15 982 break;
9ad1a37493338c Madalin Bucur 2016-11-15 983 default:
9ad1a37493338c Madalin Bucur 2016-11-15 984 dev_warn(priv->net_dev->dev.parent,
9ad1a37493338c Madalin Bucur 2016-11-15 985 "Unknown FQ type detected!\n");
9ad1a37493338c Madalin Bucur 2016-11-15 986 break;
9ad1a37493338c Madalin Bucur 2016-11-15 987 }
9ad1a37493338c Madalin Bucur 2016-11-15 988 }
9ad1a37493338c Madalin Bucur 2016-11-15 989
9ad1a37493338c Madalin Bucur 2016-11-15 990 /* Make sure all CPUs receive a corresponding Tx queue. */
9ad1a37493338c Madalin Bucur 2016-11-15 991 while (egress_cnt < DPAA_ETH_TXQ_NUM) {
9ad1a37493338c Madalin Bucur 2016-11-15 992 list_for_each_entry(fq, &priv->dpaa_fq_list, list) {
9ad1a37493338c Madalin Bucur 2016-11-15 993 if (fq->fq_type != FQ_TYPE_TX)
9ad1a37493338c Madalin Bucur 2016-11-15 994 continue;
9ad1a37493338c Madalin Bucur 2016-11-15 995 priv->egress_fqs[egress_cnt++] = &fq->fq_base;
9ad1a37493338c Madalin Bucur 2016-11-15 996 if (egress_cnt == DPAA_ETH_TXQ_NUM)
9ad1a37493338c Madalin Bucur 2016-11-15 997 break;
9ad1a37493338c Madalin Bucur 2016-11-15 998 }
9ad1a37493338c Madalin Bucur 2016-11-15 999 }
9ad1a37493338c Madalin Bucur 2016-11-15 @1000 }
9ad1a37493338c Madalin Bucur 2016-11-15 1001
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
View attachment "reproduce" of type "text/plain" (756 bytes)
View attachment "config" of type "text/plain" (339785 bytes)
Powered by blists - more mailing lists