linux-kernel - Re: [PATCH net-next 1/5] netdevice: convert private flags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240628185947.4e8cec02@kernel.org>
Date: Fri, 28 Jun 2024 18:59:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Edward Cree <ecree.xilinx@...il.com>
Cc: Alexander Lobakin <aleksander.lobakin@...el.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Xuan Zhuo
 <xuanzhuo@...ux.alibaba.com>, Andrew Lunn <andrew@...n.ch>,
 nex.sw.ncis.osdt.itp.upstreaming@...el.com, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 1/5] netdevice: convert private flags > BIT(31)
 to bitfields

On Fri, 28 Jun 2024 17:03:10 +0100 Edward Cree wrote:
> >> It generates sizeof(bitfield) which the compilers don't like and don't
> >> want to compile ._.  
> > 
> > Mm. Okay, I have no better ideas then.
> > 
> > Do consider moving the cold flags next to wol_enabled, tho?  
> 
> My RSS series moves wol_enabled out to struct ethtool_netdev_state [1] so
>  this may not be worthwhile?

Speaking of which a new bit just appeared there, for the SFP module
flashing. I'm gonna merge your series because it technically doesn't
impact it, but could you follow up and move that bit to ethtool state?