[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CANyH0kAPuxnTR0UA3EBfzd8aAFH4kw9qVN1GLi-g60VE5NUYwg@mail.gmail.com>
Date: Sun, 30 Jun 2024 13:05:03 -0400
From: Hoi Pok Wu <wuhoipok@...il.com>
To: Thomas Zimmermann <tzimmermann@...e.de>
Cc: Alex Deucher <alexander.deucher@....com>,
Christian König <christian.koenig@....com>,
"Pan, Xinhui" <Xinhui.Pan@....com>, David Airlie <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>,
amd-gfx@...ts.freedesktop.org, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/7] drm/radeon: remove load callback
Dear Thmoas,
Thanks a lot for the feedback.
I admit that my patch was a mess, sorry about that.
I have submitted a v3 to change a lot of stuff, these patches should
be able to be built now.
I also improve readability, where each patch does their own stuff.
Best regards,
Wu
On Wed, Jun 26, 2024 at 10:47 AM Thomas Zimmermann <tzimmermann@...e.de> wrote:
>
> Hi
>
> Am 24.06.24 um 17:10 schrieb Wu Hoi Pok:
> > Changes between v1 and v3:
> >
> > 1. add "ddev->dev_private = rdev;"
> > 2. include a cover letter
>
> A cover letter should briefly say what the patchset is about.
>
> BTW it's not clear to me why you need to modify radeon_dev.dev for
> removing the load callback. It seems it's a separate issue.
>
> Best regards
> Thomas
>
>
> >
> > Wu Hoi Pok (7):
> > drm/radeon: remove load callback
> > drm/radeon: rdev->ddev to rdev_to_drm(rdev) 1
> > drm/radeon: rdev->ddev to rdev_to_drm(rdev) 2
> > drm/radeon: rdev->ddev to rdev_to_drm(rdev) 3
> > drm/radeon: rdev->ddev to rdev_to_drm(rdev) 4
> > drm/radeon: rdev->ddev to rdev_to_drm(rdev) 5
> > drm/radeon: rdev->ddev to rdev_to_drm(rdev) 6
> >
> > drivers/gpu/drm/radeon/atombios_encoders.c | 2 +-
> > drivers/gpu/drm/radeon/cik.c | 14 ++--
> > drivers/gpu/drm/radeon/dce6_afmt.c | 2 +-
> > drivers/gpu/drm/radeon/evergreen.c | 12 ++--
> > drivers/gpu/drm/radeon/ni.c | 2 +-
> > drivers/gpu/drm/radeon/r100.c | 24 +++----
> > drivers/gpu/drm/radeon/r300.c | 6 +-
> > drivers/gpu/drm/radeon/r420.c | 6 +-
> > drivers/gpu/drm/radeon/r520.c | 2 +-
> > drivers/gpu/drm/radeon/r600.c | 12 ++--
> > drivers/gpu/drm/radeon/r600_cs.c | 2 +-
> > drivers/gpu/drm/radeon/r600_dpm.c | 4 +-
> > drivers/gpu/drm/radeon/r600_hdmi.c | 2 +-
> > drivers/gpu/drm/radeon/radeon.h | 11 +++-
> > drivers/gpu/drm/radeon/radeon_acpi.c | 10 +--
> > drivers/gpu/drm/radeon/radeon_agp.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_atombios.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_audio.c | 4 +-
> > drivers/gpu/drm/radeon/radeon_combios.c | 12 ++--
> > drivers/gpu/drm/radeon/radeon_device.c | 19 ++----
> > drivers/gpu/drm/radeon/radeon_display.c | 74 +++++++++++-----------
> > drivers/gpu/drm/radeon/radeon_drv.c | 27 +++++---
> > drivers/gpu/drm/radeon/radeon_drv.h | 1 -
> > drivers/gpu/drm/radeon/radeon_fbdev.c | 26 ++++----
> > drivers/gpu/drm/radeon/radeon_fence.c | 8 +--
> > drivers/gpu/drm/radeon/radeon_gem.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_i2c.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_ib.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_irq_kms.c | 12 ++--
> > drivers/gpu/drm/radeon/radeon_kms.c | 18 ++----
> > drivers/gpu/drm/radeon/radeon_object.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_pm.c | 20 +++---
> > drivers/gpu/drm/radeon/radeon_ring.c | 2 +-
> > drivers/gpu/drm/radeon/radeon_ttm.c | 6 +-
> > drivers/gpu/drm/radeon/rs400.c | 6 +-
> > drivers/gpu/drm/radeon/rs600.c | 14 ++--
> > drivers/gpu/drm/radeon/rs690.c | 2 +-
> > drivers/gpu/drm/radeon/rv515.c | 4 +-
> > drivers/gpu/drm/radeon/rv770.c | 2 +-
> > drivers/gpu/drm/radeon/si.c | 4 +-
> > 40 files changed, 193 insertions(+), 191 deletions(-)
> >
>
> --
> --
> Thomas Zimmermann
> Graphics Driver Developer
> SUSE Software Solutions Germany GmbH
> Frankenstrasse 146, 90461 Nuernberg, Germany
> GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
> HRB 36809 (AG Nuernberg)
>
Powered by blists - more mailing lists