linux-kernel - Re: [PATCH 2/5] vdso: Add comment about reason for vdso struct ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ca4f5359-0999-440b-be5d-becfe7f500c8@arm.com>
Date: Mon, 1 Jul 2024 16:10:39 +0100
From: Vincenzo Frascino <vincenzo.frascino@....com>
To: Anna-Maria Behnsen <anna-maria@...utronix.de>,
 Andy Lutomirski <luto@...nel.org>, Thomas Gleixner <tglx@...utronix.de>
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] vdso: Add comment about reason for vdso struct
 ordering



On 01/07/2024 15:47, Anna-Maria Behnsen wrote:
> Signed-off-by: Anna-Maria Behnsen <anna-maria@...utronix.de>

nit: Can you please add something in the commit message?

Otherwise:

Reviewed-by: Vincenzo Frascino <vincenzo.frascino@....com>

> ---
>  include/vdso/datapage.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/vdso/datapage.h b/include/vdso/datapage.h
> index d04d394db064..7647e0946f50 100644
> --- a/include/vdso/datapage.h
> +++ b/include/vdso/datapage.h
> @@ -77,6 +77,10 @@ struct vdso_timestamp {
>   * vdso_data will be accessed by 64 bit and compat code at the same time
>   * so we should be careful before modifying this structure.
>   *
> + * The ordering of the struct members is optimized to have fast access to the
> + * often required struct members which are related to CLOCK_REALTIME and
> + * CLOCK_MONOTONIC. This information is stored in the first cache lines.
> + *
>   * @basetime is used to store the base time for the system wide time getter
>   * VVAR page.
>   *
> 

-- 
Regards,
Vincenzo