linux-kernel - Re: [PATCH v4] tty: serial: ma35d1: Add a NULL check for of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e3cfc874-e590-4b4b-8822-972d8c7fc98c@suswa.mountain>
Date: Mon, 1 Jul 2024 17:10:52 +0200
From: Dan Carpenter <dan.carpenter@...aro.org>
To: Jacky Huang <ychuang570808@...il.com>
Cc: gregkh@...uxfoundation.org, jirislaby@...nel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Jacky Huang <ychuang3@...oton.com>
Subject: Re: [PATCH v4] tty: serial: ma35d1: Add a NULL check for of_node

On Tue, Jun 25, 2024 at 06:41:28AM +0000, Jacky Huang wrote:
> From: Jacky Huang <ychuang3@...oton.com>
> 
> The pdev->dev.of_node can be NULL if the "serial" node is absent.
> Add a NULL check to return an error in such cases.
> 
> Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support")
> Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
> Closes: https://lore.kernel.org/all/8df7ce45-fd58-4235-88f7-43fe7cd67e8f@moroto.mountain/
> Signed-off-by: Jacky Huang <ychuang3@...oton.com>
> ---
>   V3 -> V4: Move the version info lines to the correct position.
>   V2 -> V3: Added the "Reported-by:" line.
>   V1 -> V2: Added the "Fixes" line.

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@...aro.org>

regards,
dan carpenter