linux-kernel - Re: [PATCH 0/3] Add Per-transport SCMI debug statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jul 2024 16:20:52 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Luke Parkin <luke.parkin@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org, sudeep.holla@....com,
	cristian.marussi@....com
Subject: Re: [PATCH 0/3] Add Per-transport SCMI debug statistics

On Mon, Jul 01, 2024 at 03:28:48PM +0100, Luke Parkin wrote:
> Hi,
> 

Hi Luke,

thanks for taking a shot at this, a few comments down below and along
this series.

> This series adds support for tracking Arm SCMI statistics, [Patch 2]
> A config option to enable this, [Patch 1] 
> And in [Patch 3] a selection of new debugfs entries to present these statistics
> 
> These statistics are per transport instance, and will be a helpful resource when
> debugging the SCMI and running tests.
> 
> Based on v6.9, Tested on Arm Juno [1]
> 

First of all a nitpick on commit messages themselves...when posting patches on a specific
subsystem, the commit message "style" should align with the subsystem conventions:
IOW all the patches in your series (beside this cover-letter) should be titled as:

  firmware: arm_scmi: My patch starting with a capital letter

as you can guess having a look at git log --oneline drivers/firmware/arm_scmi

So please do this in V2 together with other reviews.

Thanks,
Cristian