linux-kernel - Re: [PATCH 1/3] Add Kconfig option for scmi debug statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZoLMF5AFa60iefpA@pluto>
Date: Mon, 1 Jul 2024 16:32:39 +0100
From: Cristian Marussi <cristian.marussi@....com>
To: Luke Parkin <luke.parkin@....com>
Cc: linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	arm-scmi@...r.kernel.org, sudeep.holla@....com,
	cristian.marussi@....com
Subject: Re: [PATCH 1/3] Add Kconfig option for scmi debug statistics

On Mon, Jul 01, 2024 at 03:28:49PM +0100, Luke Parkin wrote:
> Add a new config option for statistic tracking in SCMI subsystem.
> 
> Signed-off-by: Luke Parkin <luke.parkin@....com>
> ---
>  drivers/firmware/arm_scmi/Kconfig | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 

Hi,

> diff --git a/drivers/firmware/arm_scmi/Kconfig b/drivers/firmware/arm_scmi/Kconfig
> index aa5842be19b2..fac50fd0be72 100644
> --- a/drivers/firmware/arm_scmi/Kconfig
> +++ b/drivers/firmware/arm_scmi/Kconfig
> @@ -55,6 +55,16 @@ config ARM_SCMI_RAW_MODE_SUPPORT_COEX
>  	  operate normally, thing which could make an SCMI test suite using the
>  	  SCMI Raw mode support unreliable. If unsure, say N.
>  
> +config ARM_SCMI_DEBUG_STATISTICS
> +	bool "Enable SCMI Raw mode statistic tracking"

I would add also a depends on DEBUG_FS like in RAW...and maybe in the
future move such all of such depends on ARM_SCMI_NEED_DEBUGFS
instead...but for now it is easier and less potentially disruptive to
the build to just add a depends here.

> +	select ARM_SCMI_NEED_DEBUGFS
> +	help
> +	  Enables statistic tracking for the SCMI subsystem.
> +
> +	  Enable this option to create a new debugfs directory which contains
> +	  several useful statistics on various SCMI features. This can be useful
> +	  for debugging and SCMI monitoring. If unsure, say N.
> +

Moreover you should move this Kconfig patch after the patches in the
series that includes the logic underneath this...here really you are
defining some option that, if enabled, at this point it really still
does NOT enable anything.

Thanks,
Cristian