linux-kernel - Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b565856a28cff8e01fc1dbb6a776067a3467af9c.camel@kernel.org>
Date: Mon, 01 Jul 2024 15:27:28 +0000
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Francesco Dolcini <francesco@...cini.it>
Cc: Vitor Soares <ivitro@...il.com>, Peter Huewe <peterhuewe@....de>, Jason
 Gunthorpe <jgg@...pe.ca>, Lukas Wunner <lukas@...ner.de>, Vitor Soares
 <vitor.soares@...adex.com>,  linux-integrity@...r.kernel.org,
 linux-kernel@...r.kernel.org,  stable@...r.kernel.org
Subject: Re: [PATCH v1] tpm_tis_spi: add missing attpm20p SPI device ID entry

On Mon, 2024-07-01 at 17:14 +0200, Francesco Dolcini wrote:
> On Mon, Jul 01, 2024 at 03:02:11PM +0000, Jarkko Sakkinen wrote:
> > On Fri, 2024-06-21 at 10:50 +0100, Vitor Soares wrote:
> > > From: Vitor Soares <vitor.soares@...adex.com>
> > > 
> > > "atmel,attpm20p" DT compatible is missing its SPI device ID entry, not
> > > allowing module autoloading and leading to the following message:
> > > 
> > >   "SPI driver tpm_tis_spi has no spi_device_id for atmel,attpm20p"
> > > 
> > > Based on:
> > >   commit 7eba41fe8c7b ("tpm_tis_spi: Add missing SPI ID")
> > > 
> > > Fix this by adding the corresponding "attpm20p" spi_device_id entry.
> > > 
> > > Fixes: 3c45308c44ed ("tpm_tis_spi: Add compatible string atmel,attpm20p")
> > > Cc: stable@...r.kernel.org
> > > Signed-off-by: Vitor Soares <vitor.soares@...adex.com>
> > 
> > This is not a bug fix. This is a feature.
> 
> I believe that some maintainer have a different view on this kind of
> patches compared to you, adding new device id would be material for
> stable, or this specific issue preventing module auto loading.
> 
> I noticed that this specific view is not new from you, see
> https://lore.kernel.org/all/CY54PJM8KY92.UOCXW1JQUVF7@suppilovahvero/.
> 
> With that said, I am ok with it.
> 
> Do you want a new patch version without Fixes/Cc:stable tags or you can
> remove those while applying?
> 
> Francesco

Hmm... OK, I'll apply this version, I see your point here!

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

BR, Jarkko