[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ba1ac5bb-ee58-406b-9f49-54327696a6a8@lunn.ch>
Date: Mon, 1 Jul 2024 18:44:33 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 2/6] net: phy: dp83869: Perform software restart
after configuring op mode
On Mon, Jul 01, 2024 at 10:51:04AM +0200, Romain Gantois wrote:
> The DP83869 PHY requires a software restart after OP_MODE is changed in the
> OP_MODE_DECODE register.
>
> Add this restart in dp83869_configure_mode().
>
> Signed-off-by: Romain Gantois <romain.gantois@...tlin.com>
> ---
> drivers/net/phy/dp83869.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/net/phy/dp83869.c b/drivers/net/phy/dp83869.c
> index f6b05e3a3173e..6bb9bb1c0e962 100644
> --- a/drivers/net/phy/dp83869.c
> +++ b/drivers/net/phy/dp83869.c
> @@ -786,6 +786,10 @@ static int dp83869_configure_mode(struct phy_device *phydev,
Not directly this patch, but dp83869_configure_mode() has:
ret = phy_write(phydev, MII_BMCR, MII_DP83869_BMCR_DEFAULT);
where #define MII_DP83869_BMCR_DEFAULT (BMCR_ANENABLE | \
BMCR_FULLDPLX | \
BMCR_SPEED1000)
When considering the previous patch, maybe BMCR_ANENABLE should be
conditional on the mode being selected?
Andrew
Powered by blists - more mailing lists