linux-kernel - Re: [PATCH net-next 4/6] net: phy: dp83869: Support 1000Base-X and 100Base-FX SFP modules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <21081e48-0f96-463f-a01a-959eb71bdb40@lunn.ch>
Date: Mon, 1 Jul 2024 18:49:25 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Romain Gantois <romain.gantois@...tlin.com>
Cc: Heiner Kallweit <hkallweit1@...il.com>,
	Russell King <linux@...linux.org.uk>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next 4/6] net: phy: dp83869: Support 1000Base-X and
 100Base-FX SFP modules

> +	dev_info(&phydev->mdio.dev, "%s SFP compatible link mode: %s\n", __func__,
> +		 phy_modes(interface));

Maybe phydev_debug().

> +
> +	dp83869 = phydev->priv;
> +
> +	switch (interface) {
> +	case PHY_INTERFACE_MODE_100BASEX:
> +		dp83869->mode = DP83869_RGMII_100_BASE;
> +		phydev->port = PORT_FIBRE;
> +		break;
> +	case PHY_INTERFACE_MODE_1000BASEX:
> +		dp83869->mode = DP83869_RGMII_1000_BASE;
> +		phydev->port = PORT_FIBRE;
> +		break;
> +	default:
> +		dev_err(&phydev->mdio.dev,
> +			"incompatible PHY-to-SFP module link mode %s!\n",
> +			phy_modes(interface));

phydev_err()?


    Andrew

---
pw-bot: cr