linux-kernel - Re: [PATCH v2 2/3] dt-bindings: pwm: amlogic: Add optional power-domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240701183631.GA349021-robh@kernel.org>
Date: Mon, 1 Jul 2024 12:36:31 -0600
From: Rob Herring <robh@...nel.org>
To: George Stark <gnstark@...utedevices.com>
Cc: ukleinek@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
	neil.armstrong@...aro.org, khilman@...libre.com,
	jbrunet@...libre.com, martin.blumenstingl@...glemail.com,
	hkallweit1@...il.com, linux-pwm@...r.kernel.org,
	devicetree@...r.kernel.org, linux-amlogic@...ts.infradead.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	kernel@...utedevices.com
Subject: Re: [PATCH v2 2/3] dt-bindings: pwm: amlogic: Add optional
 power-domains

On Mon, Jul 01, 2024 at 08:20:15PM +0300, George Stark wrote:
> On newer SoCs, the PWM can require a power-domain to operate so add it
> as optional.

If required, then how is it optional?

If the 'newer SoCs' means the one you just added, then this should be 
squashed into the prior patch with a conditional schema making it 
required for the new compatible.

> 
> Signed-off-by: George Stark <gnstark@...utedevices.com>
> ---
>  Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> index da22cb3ed878..c814d88748dd 100644
> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
> @@ -60,6 +60,9 @@ properties:
>      minItems: 1
>      maxItems: 2
>  
> +  power-domains:
> +    maxItems: 1
> +
>    "#pwm-cells":
>      const: 3
>  
> -- 
> 2.25.1
>