linux-kernel - Re: [PATCH v2 2/3] dt-bindings: pwm: amlogic: Add optional power-domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66278f9c-3dde-420a-b446-69693690dc10@salutedevices.com>
Date: Tue, 2 Jul 2024 15:29:27 +0300
From: George Stark <gnstark@...utedevices.com>
To: Rob Herring <robh@...nel.org>
CC: <ukleinek@...nel.org>, <krzk+dt@...nel.org>, <conor+dt@...nel.org>,
	<neil.armstrong@...aro.org>, <khilman@...libre.com>, <jbrunet@...libre.com>,
	<martin.blumenstingl@...glemail.com>, <hkallweit1@...il.com>,
	<linux-pwm@...r.kernel.org>, <devicetree@...r.kernel.org>,
	<linux-amlogic@...ts.infradead.org>, <linux-arm-kernel@...ts.infradead.org>,
	<linux-kernel@...r.kernel.org>, <kernel@...utedevices.com>
Subject: Re: [PATCH v2 2/3] dt-bindings: pwm: amlogic: Add optional
 power-domains

Hello Rob

Thanks for the review.

On 7/1/24 21:36, Rob Herring wrote:
> On Mon, Jul 01, 2024 at 08:20:15PM +0300, George Stark wrote:
>> On newer SoCs, the PWM can require a power-domain to operate so add it
>> as optional.
> 
> If required, then how is it optional?

Newly adding SoC's PWM definitely requires power-domains, older SoCs
don't have dedicated power-domain for that that kind of periphery.
But I can't say other new SoCs won't require it too that's why I made it
by a separate patch. And squash the power-domians patch into main one
is ok too.

> 
> If the 'newer SoCs' means the one you just added, then this should be
> squashed into the prior patch with a conditional schema making it
> required for the new compatible.

> 
>>
>> Signed-off-by: George Stark <gnstark@...utedevices.com>
>> ---
>>   Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> index da22cb3ed878..c814d88748dd 100644
>> --- a/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/pwm/pwm-amlogic.yaml
>> @@ -60,6 +60,9 @@ properties:
>>       minItems: 1
>>       maxItems: 2
>>   
>> +  power-domains:
>> +    maxItems: 1
>> +
>>     "#pwm-cells":
>>       const: 3
>>   
>> -- 
>> 2.25.1
>>

-- 
Best regards
George