linux-kernel - Re: [PATCH] drm/fbdev-dma: Fix framebuffer mode for big endian devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1093718b-5ec1-4eab-996b-f688bf9a1c03@suse.de>
Date: Tue, 2 Jul 2024 14:29:18 +0200
From: Thomas Zimmermann <tzimmermann@...e.de>
To: Thomas Huth <thuth@...hat.com>, dri-devel@...ts.freedesktop.org,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: linux-kernel@...r.kernel.org, David Airlie <airlied@...il.com>,
 Daniel Vetter <daniel@...ll.ch>,
 Javier Martinez Canillas <javierm@...hat.com>
Subject: Re: [PATCH] drm/fbdev-dma: Fix framebuffer mode for big endian
 devices

Hi

Am 02.07.24 um 14:17 schrieb Thomas Huth:
> The drm_mode_legacy_fb_format() function only generates formats suitable
> for little endian devices. switch to drm_driver_legacy_fb_format() here
> instead to take the device endianness into consideration, too.
>
> Suggested-by: Thomas Zimmermann <tzimmermann@...e.de>
> Signed-off-by: Thomas Huth <thuth@...hat.com>

Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>

Thank you for taking the time to make the patch for fbdev-dma. I'll take 
care of merging both patches into the correct branches.

Best regards
Thomas

> ---
>   Note: Patch has only been compile-tested since I lack an environment
>         for testing it. But it's the same fix as I required for the
>         drm_mode_legacy_fb_format() in drm_fbdev_generic.c / drm_fbdev_ttm.c
>         so I think this should be fine.
>
>   drivers/gpu/drm/drm_fbdev_dma.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fbdev_dma.c b/drivers/gpu/drm/drm_fbdev_dma.c
> index 97ef6300d47e..fdef4a2f883f 100644
> --- a/drivers/gpu/drm/drm_fbdev_dma.c
> +++ b/drivers/gpu/drm/drm_fbdev_dma.c
> @@ -101,7 +101,8 @@ static int drm_fbdev_dma_helper_fb_probe(struct drm_fb_helper *fb_helper,
>   		    sizes->surface_width, sizes->surface_height,
>   		    sizes->surface_bpp);
>   
> -	format = drm_mode_legacy_fb_format(sizes->surface_bpp, sizes->surface_depth);
> +	format = drm_driver_legacy_fb_format(dev, sizes->surface_bpp,
> +					     sizes->surface_depth);
>   	buffer = drm_client_framebuffer_create(client, sizes->surface_width,
>   					       sizes->surface_height, format);
>   	if (IS_ERR(buffer))

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)