linux-kernel - Re: [PATCH v2] efi: libstub: add support for the apple_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMj1kXFuKstumJnygLi_hhu+6OrtjrPEX+SX=GELrU4sthAV7A@mail.gmail.com>
Date: Mon, 1 Jul 2024 07:11:22 +0200
From: Ard Biesheuvel <ardb@...nel.org>
To: Orlando Chamberlain <orlandoch.dev@...il.com>
Cc: Aditya Garg <gargaditya08@...e.com>, Hans de Goede <hdegoede@...hat.com>, 
	Lukas Wunner <lukas@...ner.de>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, 
	"linux-efi@...r.kernel.org" <linux-efi@...r.kernel.org>, Kerem Karabay <kekrby@...il.com>
Subject: Re: [PATCH v2] efi: libstub: add support for the apple_set_os protocol

On Mon, 1 Jul 2024 at 06:46, Orlando Chamberlain
<orlandoch.dev@...il.com> wrote:
>
>
> On Mon, 1 Jul 2024 at 05:24, Aditya Garg <gargaditya08@...e.com> wrote:
> >
> > From: Aditya Garg <gargaditya08@...e.com>
> >
> > 0c18184de990 ("platform/x86: apple-gmux: support MMIO gmux on T2 Macs")
> > brought support for T2 Macs in apple-gmux. But in order to use dual GPU,
> > the integrated GPU has to be enabled. On such dual GPU EFI Macs, the EFI
> > stub needs to report that it is booting macOS in order to prevent the
> > firmware from disabling the iGPU.
> >
> > This patch is also applicable for some non T2 Intel Macs.
> >
> > Based on this patch for GRUB by Andreas Heider <andreas@...der.io>:
> > https://lists.gnu.org/archive/html/grub-devel/2013-12/msg00442.html
> >
> > Credits also goto Kerem Karabay <kekrby@...il.com> for helping porting
> > the patch to the Linux kernel.
> >
> > Signed-off-by: Aditya Garg <gargaditya08@...e.com>

> I've checked that this patch works for me when applied to 6.10-rc6.
> I can also use https://github.com/0xbb/gpu-switch to make the boot gpu
> the iGPU now.
>
> Tested-By: Orlando Chamberlain <orlandoch.dev@...il.com> (MacBookPro16,1)
>

Thanks.

Is there any point to making this set_os() call if CONFIG_APPLE_GMUX
is not enabled?